From: Kevin Hilman <khilman@deeprootsystems.com>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] PM: Fix compile error
Date: Tue, 25 Nov 2008 10:34:37 -0800 [thread overview]
Message-ID: <878wr7psci.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1227253118-32169-1-git-send-email-premi@ti.com> (Sanjeev Premi's message of "Fri\, 21 Nov 2008 13\:08\:38 +0530")
Sanjeev,
Sanjeev Premi <premi@ti.com> writes:
> Function pm_dbg_update_time() is defined in within
> an #ifdef CONFIG_DEBUG_FS; leading to this error:
>
> arch/arm/mach-omap2/built-in.o: In function `_pwrdm_state_switch':
> /db/psp_git/users/a0756819/omap-kern-latest/arch/arm/mach-omap2/powerdomain.c:139: undefined reference to `pm_dbg_update_time'
>
Thanks. I have a similar fix for this already staged for the next PM branch.
Kevin
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
> arch/arm/mach-omap2/powerdomain.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
> index 0334609..081b3b6 100644
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -136,7 +136,9 @@ static int _pwrdm_state_switch(struct powerdomain *pwrdm, int flag)
> if (state != prev)
> pwrdm->state_counter[state]++;
>
> +#ifdef CONFIG_DEBUG_FS
> pm_dbg_update_time(pwrdm, prev);
> +#endif
>
> pwrdm->state = state;
>
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-11-25 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 7:38 [PATCH] PM: Fix compile error Sanjeev Premi
2008-11-25 18:34 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wr7psci.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox