[balbi-usb:testing/next 31/41] drivers/usb/mtu3/mtu3_qmu.c:261:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}'

[balbi-usb:testing/next 31/41] drivers/usb/mtu3/mtu3_qmu.c:261:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4005 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
head:   f2fedb17e8946a24c9cf2bd20ee466fb8659196a
commit: 46ed5b0c1fac208e727c8cea6c2db44a77fc256a [31/41] usb: mtu3: support 36-bit DMA address
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 46ed5b0c1fac208e727c8cea6c2db44a77fc256a
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:13,
                    from include/asm-generic/bug.h:15,
                    from arch/mips/include/asm/bug.h:41,
                    from include/linux/bug.h:4,
                    from include/linux/scatterlist.h:6,
                    from include/linux/dmapool.h:14,
                    from drivers/usb/mtu3/mtu3_qmu.c:30:
   drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_tx_gpd':
>> drivers/usb/mtu3/mtu3_qmu.c:261:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
                            ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/usb/mtu3/mtu3_qmu.c:261:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
     ^~~~~~~
   drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_rx_gpd':
   drivers/usb/mtu3/mtu3_qmu.c:300:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     dev_dbg(mep->mtu->dev, "RX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
                            ^
   include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/usb/mtu3/mtu3_qmu.c:300:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(mep->mtu->dev, "RX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
     ^~~~~~~

vim +261 drivers/usb/mtu3/mtu3_qmu.c

   240	
   241	static int mtu3_prepare_tx_gpd(struct mtu3_ep *mep, struct mtu3_request *mreq)
   242	{
   243		struct qmu_gpd *enq;
   244		struct mtu3_gpd_ring *ring = &mep->gpd_ring;
   245		struct qmu_gpd *gpd = ring->enqueue;
   246		struct usb_request *req = &mreq->request;
   247		dma_addr_t enq_dma;
   248		u16 ext_addr;
   249	
   250		/* set all fields to zero as default value */
   251		memset(gpd, 0, sizeof(*gpd));
   252	
   253		gpd->buffer = cpu_to_le32(lower_32_bits(req->dma));
   254		ext_addr = GPD_EXT_BUF(upper_32_bits(req->dma));
   255		gpd->buf_len = cpu_to_le16(req->length);
   256		gpd->flag |= GPD_FLAGS_IOC;
   257	
   258		/* get the next GPD */
   259		enq = advance_enq_gpd(ring);
   260		enq_dma = gpd_virt_to_dma(ring, enq);
 > 261		dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
   262			mep->epnum, gpd, enq, enq_dma);
   263	
   264		enq->flag &= ~GPD_FLAGS_HWO;
   265		gpd->next_gpd = cpu_to_le32(lower_32_bits(enq_dma));
   266		ext_addr |= GPD_EXT_NGP(upper_32_bits(enq_dma));
   267		gpd->tx_ext_addr = cpu_to_le16(ext_addr);
   268	
   269		if (req->zero)
   270			gpd->ext_flag |= GPD_EXT_FLAG_ZLP;
   271	
   272		gpd->chksum = qmu_calc_checksum((u8 *)gpd);
   273		gpd->flag |= GPD_FLAGS_HWO;
   274	
   275		mreq->gpd = gpd;
   276	
   277		return 0;
   278	}
   279	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47745 bytes --]

Re: [balbi-usb:testing/next 31/41] drivers/usb/mtu3/mtu3_qmu.c:261:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}'

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]


Hi,

kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
> head:   f2fedb17e8946a24c9cf2bd20ee466fb8659196a
> commit: 46ed5b0c1fac208e727c8cea6c2db44a77fc256a [31/41] usb: mtu3: support 36-bit DMA address
> config: mips-allyesconfig (attached as .config)
> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 46ed5b0c1fac208e727c8cea6c2db44a77fc256a
>         # save the attached .config to linux build tree
>         make.cross ARCH=mips 
>
> All warnings (new ones prefixed by >>):
>
>    In file included from include/linux/printk.h:329:0,
>                     from include/linux/kernel.h:13,
>                     from include/asm-generic/bug.h:15,
>                     from arch/mips/include/asm/bug.h:41,
>                     from include/linux/bug.h:4,
>                     from include/linux/scatterlist.h:6,
>                     from include/linux/dmapool.h:14,
>                     from drivers/usb/mtu3/mtu3_qmu.c:30:
>    drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_tx_gpd':
>>> drivers/usb/mtu3/mtu3_qmu.c:261:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
>      dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
>                             ^
>    include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
>       __dynamic_dev_dbg(&descriptor, dev, fmt, \
>                                           ^~~
>    drivers/usb/mtu3/mtu3_qmu.c:261:2: note: in expansion of macro 'dev_dbg'
>      dev_dbg(mep->mtu->dev, "TX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
>      ^~~~~~~
>    drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_rx_gpd':
>    drivers/usb/mtu3/mtu3_qmu.c:300:25: warning: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
>      dev_dbg(mep->mtu->dev, "RX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
>                             ^
>    include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg'
>       __dynamic_dev_dbg(&descriptor, dev, fmt, \
>                                           ^~~
>    drivers/usb/mtu3/mtu3_qmu.c:300:2: note: in expansion of macro 'dev_dbg'
>      dev_dbg(mep->mtu->dev, "RX-EP%d queue gpd=%p, enq=%p, qdma=%pad\n",
>      ^~~~~~~

odd, printk-formats.txt tells me pad is for dma_addr_t:

DMA addresses types ``dma_addr_t``
==================================

::

	%pad	0x01234567 or 0x0123456789abcdef

For printing a ``dma_addr_t`` type which can vary based on build options,
regardless of the width of the CPU data path. Passed by reference.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]