Re: [GIT PULL 3/6] omap hwmod changes for v3.13 merge window

Re: [GIT PULL 3/6] omap hwmod changes for v3.13 merge window

[Kevin Hilman]

Tony Lindgren <tony@atomide.com> writes:

> The following changes since commit d0e639c9e06d44e713170031fe05fb60ebe680af:
>
>   Linux 3.12-rc4 (2013-10-06 14:00:20 -0700)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.13/hwmod-signed
>
> for you to fetch changes up to 254f57a92987b6cde6004f58d6b847813dfb9e0e:
>
>   ARM: OMAP5: hwmod: add missing ocp2scp hwmod data (2013-10-11 15:37:05 -0700)
>
> ----------------------------------------------------------------
> omap hwmod related changes via Paul Walmsley <paul@pwsan.com>:
>
> Some OMAP hwmod changes for 3.13.  Significant changes here include:
>
> - support for moving some of the hwmod flags to DT data
>
> - support for the SSI, hardware spinlock, USB host/TLL, and RNG IP
>   blocks for various OMAPs
>
> - a fix that again decouples hwmod data changes from unrelated DT data
>   patchsets
>
> Basic test logs are available at:
>
> http://www.pwsan.com/omap/testlogs/prcm_fixes_v3.13/20131009094936/
>
> ----------------------------------------------------------------

Pulled into next/soc,

Thanks,

Kevin

Re: [GIT PULL 3/6] omap hwmod changes for v3.13 merge window

[Olof Johansson]

On Mon, Oct 14, 2013 at 03:44:44PM -0700, Kevin Hilman wrote:
> Tony Lindgren <tony@atomide.com> writes:
> 
> > The following changes since commit d0e639c9e06d44e713170031fe05fb60ebe680af:
> >
> >   Linux 3.12-rc4 (2013-10-06 14:00:20 -0700)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.13/hwmod-signed
> >
> > for you to fetch changes up to 254f57a92987b6cde6004f58d6b847813dfb9e0e:
> >
> >   ARM: OMAP5: hwmod: add missing ocp2scp hwmod data (2013-10-11 15:37:05 -0700)
> >
> > ----------------------------------------------------------------
> > omap hwmod related changes via Paul Walmsley <paul@pwsan.com>:
> >
> > Some OMAP hwmod changes for 3.13.  Significant changes here include:
> >
> > - support for moving some of the hwmod flags to DT data
> >
> > - support for the SSI, hardware spinlock, USB host/TLL, and RNG IP
> >   blocks for various OMAPs
> >
> > - a fix that again decouples hwmod data changes from unrelated DT data
> >   patchsets
> >
> > Basic test logs are available at:
> >
> > http://www.pwsan.com/omap/testlogs/prcm_fixes_v3.13/20131009094936/
> >
> > ----------------------------------------------------------------
> 
> Pulled into next/soc,
> 
> Thanks,
> 
> Kevin

Hm, looks like my BBB hit this on v3.12-rc4-493-g1a9df23, which is pushed to
to-build but not for-next yet. I'm guessing this might be what Kevin pinged me
about on IRC today but I was out and unavailable most of the day.

[    0.169527] ------------[ cut here ]------------
[    0.169585] WARNING: CPU: 0 PID: 1 at ../../arch/arm/mach-omap2/omap_hwmod.c:2438 _init+0x338/0x37c()
[    0.169602] omap_hwmod: spinlock: doesn't have mpu register target base
[    0.169616] Modules linked in:
[    0.169647] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.12.0-rc4-00493-g1a9df23 #1
[    0.169701] [<c001ba40>] (unwind_backtrace+0x0/0xec) from [<c0017b80>] (show_stack+0x10/0x14)
[    0.169735] [<c0017b80>] (show_stack+0x10/0x14) from [<c051ad90>] (dump_stack+0x7c/0x94)
[    0.169768] [<c051ad90>] (dump_stack+0x7c/0x94) from [<c0045be0>] (warn_slowpath_common+0x6c/0x90)
[    0.169796] [<c0045be0>] (warn_slowpath_common+0x6c/0x90) from [<c0045c34>] (warn_slowpath_fmt+0x30/0x40)
[    0.169825] [<c0045c34>] (warn_slowpath_fmt+0x30/0x40) from [<c076e868>] (_init+0x338/0x37c)
[    0.169855] [<c076e868>] (_init+0x338/0x37c) from [<c076ed80>] (__omap_hwmod_setup_all+0x40/0x8c)
[    0.169886] [<c076ed80>] (__omap_hwmod_setup_all+0x40/0x8c) from [<c0008848>] (do_one_initcall+0xe8/0x14c)
[    0.169924] [<c0008848>] (do_one_initcall+0xe8/0x14c) from [<c0762b84>] (kernel_init_freeable+0x104/0x1c4)
[    0.169963] [<c0762b84>] (kernel_init_freeable+0x104/0x1c4) from [<c0514c90>] (kernel_init+0x8/0x150)
[    0.170002] [<c0514c90>] (kernel_init+0x8/0x150) from [<c0013bc8>] (ret_from_fork+0x14/0x2c)
[    0.170221] ---[ end trace 1b75b31a2719ed1c ]---


-Olof

Re: [GIT PULL 3/6] omap hwmod changes for v3.13 merge window

[Olof Johansson]

On Mon, Oct 14, 2013 at 9:25 PM, Kevin Hilman <khilman@linaro.org> wrote:
>
> On Oct 14, 2013 9:12 PM, "Olof Johansson" <olof@lixom.net> wrote:
>>
>> On Mon, Oct 14, 2013 at 03:44:44PM -0700, Kevin Hilman wrote:
>> > Tony Lindgren <tony@atomide.com> writes:
>> >
>> > > The following changes since commit
>> > > d0e639c9e06d44e713170031fe05fb60ebe680af:
>> > >
>> > >   Linux 3.12-rc4 (2013-10-06 14:00:20 -0700)
>> > >
>> > > are available in the git repository at:
>> > >
>> > >   git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap
>> > > tags/omap-for-v3.13/hwmod-signed
>> > >
>> > > for you to fetch changes up to
>> > > 254f57a92987b6cde6004f58d6b847813dfb9e0e:
>> > >
>> > >   ARM: OMAP5: hwmod: add missing ocp2scp hwmod data (2013-10-11
>> > > 15:37:05 -0700)
>> > >
>> > > ----------------------------------------------------------------
>> > > omap hwmod related changes via Paul Walmsley <paul@pwsan.com>:
>> > >
>> > > Some OMAP hwmod changes for 3.13.  Significant changes here include:
>> > >
>> > > - support for moving some of the hwmod flags to DT data
>> > >
>> > > - support for the SSI, hardware spinlock, USB host/TLL, and RNG IP
>> > >   blocks for various OMAPs
>> > >
>> > > - a fix that again decouples hwmod data changes from unrelated DT data
>> > >   patchsets
>> > >
>> > > Basic test logs are available at:
>> > >
>> > > http://www.pwsan.com/omap/testlogs/prcm_fixes_v3.13/20131009094936/
>> > >
>> > > ----------------------------------------------------------------
>> >
>> > Pulled into next/soc,
>> >
>> > Thanks,
>> >
>> > Kevin
>>
>> Hm, looks like my BBB hit this on v3.12-rc4-493-g1a9df23, which is pushed
>> to
>> to-build but not for-next yet. I'm guessing this might be what Kevin
>> pinged me
>> about on IRC today but I was out and unavailable most of the day.
>
> Hmmm... mine seems to have booted fine on that build...
> http://lists.linaro.org/pipermail/kernel-build-reports/2013-October/000666.html

Well, it's a WARN_ON() not a panic, so my script probably shouldn't
have aborted the boot (and your script should have reported it :-).
Check your local log to see if you have something in there?


-Olof

Re: [GIT PULL 3/6] omap hwmod changes for v3.13 merge window

[Paul Walmsley]

Hi folks

On Mon, 14 Oct 2013, Olof Johansson wrote:

> On Mon, Oct 14, 2013 at 9:25 PM, Kevin Hilman <khilman@linaro.org> wrote:
> >
> > On Oct 14, 2013 9:12 PM, "Olof Johansson" <olof@lixom.net> wrote:
> >>
> >> On Mon, Oct 14, 2013 at 03:44:44PM -0700, Kevin Hilman wrote:
> >> > Tony Lindgren <tony@atomide.com> writes:
> >> >
> >> > > The following changes since commit
> >> > > d0e639c9e06d44e713170031fe05fb60ebe680af:
> >> > >
> >> > >   Linux 3.12-rc4 (2013-10-06 14:00:20 -0700)
> >> > >
> >> > > are available in the git repository at:
> >> > >
> >> > >   git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap
> >> > > tags/omap-for-v3.13/hwmod-signed
> >> > >
> >> > > for you to fetch changes up to
> >> > > 254f57a92987b6cde6004f58d6b847813dfb9e0e:
> >> > >
> >> > >   ARM: OMAP5: hwmod: add missing ocp2scp hwmod data (2013-10-11
> >> > > 15:37:05 -0700)
> >> > >
> >> > > ----------------------------------------------------------------
> >> > > omap hwmod related changes via Paul Walmsley <paul@pwsan.com>:
> >> > >
> >> > > Some OMAP hwmod changes for 3.13.  Significant changes here include:
> >> > >
> >> > > - support for moving some of the hwmod flags to DT data
> >> > >
> >> > > - support for the SSI, hardware spinlock, USB host/TLL, and RNG IP
> >> > >   blocks for various OMAPs
> >> > >
> >> > > - a fix that again decouples hwmod data changes from unrelated DT data
> >> > >   patchsets
> >> > >
> >> > > Basic test logs are available at:
> >> > >
> >> > > http://www.pwsan.com/omap/testlogs/prcm_fixes_v3.13/20131009094936/
> >> > >
> >> > > ----------------------------------------------------------------
> >> >
> >> > Pulled into next/soc,
> >> >
> >> > Thanks,
> >> >
> >> > Kevin
> >>
> >> Hm, looks like my BBB hit this on v3.12-rc4-493-g1a9df23, which is pushed
> >> to
> >> to-build but not for-next yet. I'm guessing this might be what Kevin
> >> pinged me
> >> about on IRC today but I was out and unavailable most of the day.
> >
> > Hmmm... mine seems to have booted fine on that build...
> > http://lists.linaro.org/pipermail/kernel-build-reports/2013-October/000666.html
> 
> Well, it's a WARN_ON() not a panic, so my script probably shouldn't
> have aborted the boot (and your script should have reported it :-).
> Check your local log to see if you have something in there?

The boot warnings can be seen here: (which is linked via the pull 
request above):

http://www.pwsan.com/omap/testlogs/prcm_fixes_v3.13/20131009094936/boot/am335xbonelt/am335x-bone/am335xbonelt_log.txt

...

omap_hwmod: spinlock: doesn't have mpu register target base

...

omap_hwmod: rng: doesn't have mpu register target base

...

The spinlock warning on AM335x will be resolved when this patch is merged:

https://lkml.org/lkml/2013/10/10/650

The rng warning will be resolved when this patch is merged:

http://marc.info/?l=linux-arm-kernel&m=137778078331134&w=2


The WARN_ON() seems a bit heavy-handed, and I'd support replacing it with 
a pr_warn(); but on the other hand, it certainly seems to have attracted 
attention to a problem that prevents these devices from being usable :-)


- Paul

Re: [GIT PULL 3/6] omap hwmod changes for v3.13 merge window

[Kevin Hilman]

On Mon, Oct 14, 2013 at 9:30 PM, Olof Johansson <olof@lixom.net> wrote:
> On Mon, Oct 14, 2013 at 9:25 PM, Kevin Hilman <khilman@linaro.org> wrote:
>>
>> On Oct 14, 2013 9:12 PM, "Olof Johansson" <olof@lixom.net> wrote:
>>>
>>> On Mon, Oct 14, 2013 at 03:44:44PM -0700, Kevin Hilman wrote:
>>> > Tony Lindgren <tony@atomide.com> writes:
>>> >
>>> > > The following changes since commit
>>> > > d0e639c9e06d44e713170031fe05fb60ebe680af:
>>> > >
>>> > >   Linux 3.12-rc4 (2013-10-06 14:00:20 -0700)
>>> > >
>>> > > are available in the git repository at:
>>> > >
>>> > >   git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap
>>> > > tags/omap-for-v3.13/hwmod-signed
>>> > >
>>> > > for you to fetch changes up to
>>> > > 254f57a92987b6cde6004f58d6b847813dfb9e0e:
>>> > >
>>> > >   ARM: OMAP5: hwmod: add missing ocp2scp hwmod data (2013-10-11
>>> > > 15:37:05 -0700)
>>> > >
>>> > > ----------------------------------------------------------------
>>> > > omap hwmod related changes via Paul Walmsley <paul@pwsan.com>:
>>> > >
>>> > > Some OMAP hwmod changes for 3.13.  Significant changes here include:
>>> > >
>>> > > - support for moving some of the hwmod flags to DT data
>>> > >
>>> > > - support for the SSI, hardware spinlock, USB host/TLL, and RNG IP
>>> > >   blocks for various OMAPs
>>> > >
>>> > > - a fix that again decouples hwmod data changes from unrelated DT data
>>> > >   patchsets
>>> > >
>>> > > Basic test logs are available at:
>>> > >
>>> > > http://www.pwsan.com/omap/testlogs/prcm_fixes_v3.13/20131009094936/
>>> > >
>>> > > ----------------------------------------------------------------
>>> >
>>> > Pulled into next/soc,
>>> >
>>> > Thanks,
>>> >
>>> > Kevin
>>>
>>> Hm, looks like my BBB hit this on v3.12-rc4-493-g1a9df23, which is pushed
>>> to
>>> to-build but not for-next yet. I'm guessing this might be what Kevin
>>> pinged me
>>> about on IRC today but I was out and unavailable most of the day.
>>
>> Hmmm... mine seems to have booted fine on that build...
>> http://lists.linaro.org/pipermail/kernel-build-reports/2013-October/000666.html
>
> Well, it's a WARN_ON() not a panic, so my script probably shouldn't
> have aborted the boot (and your script should have reported it :-).

Yes indeed, it's been on my todo list to catch/report those.

> Check your local log to see if you have something in there?

Yup, there are a few backtraces due to the warns.

Kevin

[GIT PULL 3/6] omap hwmod changes for v3.13 merge window

[Tony Lindgren]

The following changes since commit d0e639c9e06d44e713170031fe05fb60ebe680af:

  Linux 3.12-rc4 (2013-10-06 14:00:20 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v3.13/hwmod-signed

for you to fetch changes up to 254f57a92987b6cde6004f58d6b847813dfb9e0e:

  ARM: OMAP5: hwmod: add missing ocp2scp hwmod data (2013-10-11 15:37:05 -0700)

----------------------------------------------------------------
omap hwmod related changes via Paul Walmsley <paul@pwsan.com>:

Some OMAP hwmod changes for 3.13.  Significant changes here include:

- support for moving some of the hwmod flags to DT data

- support for the SSI, hardware spinlock, USB host/TLL, and RNG IP
  blocks for various OMAPs

- a fix that again decouples hwmod data changes from unrelated DT data
  patchsets

Basic test logs are available at:

http://www.pwsan.com/omap/testlogs/prcm_fixes_v3.13/20131009094936/

----------------------------------------------------------------
Benoit Cousson (1):
      ARM: OMAP5: hwmod: add missing ocp2scp hwmod data

Lokesh Vutla (1):
      ARM: AM33xx: hwmod: Add RNG module data

Rajendra Nayak (2):
      ARM: OMAP2+: hwmod: cleanup HWMOD_INIT_NO_RESET usage
      ARM: OMAP2+: hwmod: Extract no-idle and no-reset info from DT

Roger Quadros (1):
      ARM: OMAP5: hwmod data: Add USB Host and TLL modules

Sebastian Reichel (1):
      ARM: OMAP2+: hwmod data: Add SSI information

Suman Anna (3):
      ARM: OMAP2+: hwmod: check for module address space during init
      ARM: OMAP5: hwmod data: Add spinlock data
      ARM: AM33xx: hwmod_data: add the sysc configuration for spinlock

Tony Lindgren (1):
      Merge tag 'for-v3.13/hwmod' of git://git.kernel.org/.../pjw/omap-pending into omap-for-v3.13/hwmod

 arch/arm/mach-omap2/omap_hwmod.c           |  49 ++++--
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c |  67 +++++++--
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  48 ++++++
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |   6 +-
 arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 230 ++++++++++++++++++++++++++++-
 5 files changed, 370 insertions(+), 30 deletions(-)