From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] omap1: select GENERIC_IRQ_CHIP for TI OMAP1 Date: Mon, 18 Jul 2011 07:52:07 -0700 Message-ID: <87aacbmyjs.fsf@ti.com> References: <1309251943.3984.1.camel@phoenix> <87boxi2eep.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: (Axel Lin's message of "Sun, 17 Jul 2011 21:38:56 +0800") Sender: linux-kernel-owner@vger.kernel.org To: axel.lin@gmail.com Cc: linux-kernel@vger.kernel.org, Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Axel Lin writes: > 2011/6/28 Kevin Hilman : >> Axel Lin writes: >> >>> The gpio-omap driver has been converted to use generic IRQ chip. >>> Thus select GENERIC_IRQ_CHIP for TI OMAP1 to fix below build error. >>> >>> =C2=A0 LD =C2=A0 =C2=A0 =C2=A0vmlinux >>> drivers/built-in.o: In function `omap_mpuio_alloc_gc': >>> drivers/gpio/gpio-omap.c:1087: undefined reference to `irq_alloc_ge= neric_chip' >>> drivers/gpio/gpio-omap.c:1100: undefined reference to `irq_setup_ge= neric_chip' >>> drivers/built-in.o: In function `omap_gpio_show_rev': >>> drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_c= lr_bit' >>> drivers/gpio/gpio-omap.c:998: undefined reference to `irq_gc_mask_s= et_bit' >>> make: *** [vmlinux] Error 1 >>> >>> Signed-off-by: Axel Lin >> >> Thanks, I have a fix for this already queued for v3.0-rc3 series: >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0http://marc.info/?l=3Dlinux-omap&m=3D1307= 49135312468&w=3D2 >> >=20 > Seems this patch is not upstream. > I still have the same build error with [linux-next: Tree for July 16= ]. Hmm, you're right. Tony hasn't queued that fix yet. Tony? Kevin