Re: [PATCH v4 1/4] TI816X: Update common omap platform files

[Kevin Hilman <khilman@ti.com>]

"Pedanekar, Hemant" <hemantp@ti.com> writes:

> Hi Kevin,
>
> Hilman, Kevin wrote on Saturday, January 22, 2011 4:01 AM:
>
>> Hi Hemant,
>> 
>> Hemant Pedanekar <hemantp@ti.com> writes:
>> 
>>> This patch updates the common platform files with TI816X support. Also
>>> adds new files for TI816X module base addresses and irq definitions.
>> [...]
>> 
>>> diff --git a/arch/arm/plat-omap/include/plat/irqs-ti816x.h
>> b/arch/arm/plat-omap/include/plat/irqs-ti816x.h
>>> new file mode 100644
>>> index 0000000..3ec5d1b
> [...]
>>> +#define TI816X_IRQ_SECPUBINT	116
>>> +#define TI816X_IRQ_SECSECINT	117
>>> +#define TI816X_IRQ_SECPUBSWINT	118
>>> +#define TI816X_IRQ_SECSECSWINT	119
>>> +#define TI816X_IRQ_SMRFLX0	120
>>> +#define TI816X_IRQ_SMRFLX1	121
>>> +#define TI816X_IRQ_SYS_MMU	122
>>> +#define TI816X_IRQ_MC_MMU	123
>>> +#define TI816X_IRQ_DMM		124
>>> +
>>> +
>>> +#endif
>> 
>> For new platforms, We don't need to have a list of all the
>> IRQ numbers.
>> 
>> Driver code should always be getting IRQ numbers (and base addresses
>> etc.) from struct resource/platform_data, which is populated
>> from omap_hwmod.
>>
>
> Are you suggesting to get rid of this file altogether or the IRQs which 
> may never be used from kernel be removed from this file (and added later
> If needed)?
>   
> Or shall I add this file only in hwmod patch which will be submitted later?

You can get rid of the file altogether.  Even the hwmod data can just
have IRQ numbers and you shouldn't need to add a header file with the
defines.

Kevin