From: Kevin Hilman <khilman@deeprootsystems.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>, Tony <tony@atomide.com>,
Thomas <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH v4 2/3] omap4: opp: add OPP table data
Date: Mon, 22 Nov 2010 15:19:41 -0800 [thread overview]
Message-ID: <87aal1kktu.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1289933661-19505-3-git-send-email-nm@ti.com> (Nishanth Menon's message of "Tue, 16 Nov 2010 12:54:20 -0600")
Nishanth Menon <nm@ti.com> writes:
> This patch adds OPP tables for OMAP4. New file has been added to keep
> the OMAP4 opp tables and the registration of these tables with the
> generic opp framework by OMAP SoC OPP interface.
[...]
> diff --git a/arch/arm/mach-omap2/opp.c b/arch/arm/mach-omap2/opp.c
> index 66e12be..48a553f 100644
> --- a/arch/arm/mach-omap2/opp.c
> +++ b/arch/arm/mach-omap2/opp.c
> @@ -131,4 +131,5 @@ static int __init omap_init_opp_table(struct omap_opp_def *opp_def,
>
> /* omap3 opps */
> #include "opp3xxx_data.c"
> -
> +/* omap4 opps */
> +#include "opp4xxx_data.c"
I'm not sure I like the including of C files. Any reason you prefer
this to just adding them to the Makefile? e.g. opp24xx_dta.c are
compiled in via Makefile and these two are included.
I vote for consistency.
Kevin
next prev parent reply other threads:[~2010-11-22 23:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init>
2010-11-16 18:54 ` [PATCH v4 0/3] OMAP: Add opp data Nishanth Menon
2010-11-16 18:54 ` [PATCH v4 1/3] omap: opp: add OMAP3 OPP table data and common init Nishanth Menon
2010-11-22 22:21 ` Kevin Hilman
2010-11-16 18:54 ` [PATCH v4 2/3] omap4: opp: add OPP table data Nishanth Menon
2010-11-22 22:45 ` Kevin Hilman
2010-11-22 22:53 ` Nishanth Menon
2010-11-22 23:12 ` Kevin Hilman
2010-11-22 23:19 ` Kevin Hilman [this message]
2010-11-22 23:30 ` Nishanth Menon
2010-11-23 0:09 ` Kevin Hilman
2010-11-23 15:19 ` Nishanth Menon
2010-11-23 20:38 ` Kevin Hilman
2010-11-23 22:33 ` Cousson, Benoit
2010-11-23 22:56 ` Nishanth Menon
2010-11-23 23:30 ` Cousson, Benoit
2010-11-24 0:16 ` Kevin Hilman
2010-11-24 2:34 ` Nishanth Menon
2010-11-16 18:54 ` [PATCH v3 3/3] OMAP3: remove OPP interfaces from OMAP PM layer Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aal1kktu.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox