From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 03/16] OMAP3: PM: Convert smartreflex driver into a platform driver using hwmods and omap-device layer Date: Fri, 12 Mar 2010 16:36:56 -0800 Message-ID: <87aaud2h1z.fsf@deeprootsystems.com> References: <1267003757-22456-1-git-send-email-thara@ti.com> <1267003757-22456-2-git-send-email-thara@ti.com> <1267003757-22456-3-git-send-email-thara@ti.com> <1267003757-22456-4-git-send-email-thara@ti.com> <87hboyy3wi.fsf@deeprootsystems.com> <5A47E75E594F054BAF48C5E4FC4B92AB0321EC965D@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:52241 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935828Ab0CMAhA (ORCPT ); Fri, 12 Mar 2010 19:37:00 -0500 Received: by pwi1 with SMTP id 1so1079718pwi.19 for ; Fri, 12 Mar 2010 16:36:59 -0800 (PST) In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0321EC965D@dbde02.ent.ti.com> (Thara Gopinath's message of "Fri\, 12 Mar 2010 15\:18\:54 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Gopinath, Thara" Cc: "linux-omap@vger.kernel.org" , "paul@pwsan.com" , "Menon, Nishanth" , "Cousson, Benoit" , "Sripathy, Vishwanath" , "Sawant, Anand" "Gopinath, Thara" writes: >>>-----Original Message----- >>>From: Kevin Hilman [mailto:khilman@deeprootsystems.com] >>>Sent: Tuesday, March 02, 2010 11:58 PM >>>To: Gopinath, Thara >>>Cc: linux-omap@vger.kernel.org; paul@pwsan.com; Menon, Nishanth; Cousson, Benoit; Sripathy, >>>Vishwanath; Sawant, Anand >>>Subject: Re: [PATCH 03/16] OMAP3: PM: Convert smartreflex driver into a platform driver using hwmods >>>and omap-device layer >>> >>>Thara Gopinath writes: >>> >>>> This patch converts the exisitng smartreflex library into a >>>> platform driver with device , driver registrations using hardware mods. >>>> As part of this Ntarget values are passed as platform data. >>>> >>>> Signed-off-by: Thara Gopinath >>> >>>Nice work Thara. This is good. Some minor comments below, but some >>>general comments first. >>> >>>As discussed, eventually (longer term) we'll want to move the driver >>>parts of this to a regulator driver. To ease that transition, I think >>>it would be nice to start now by separating the driver portions of >>>this file from the device portions. >>> >>>You've already done a good job of keeping them separate in this file >>>(most of the device stuff is at the end) but I think having a separate >>>file is probably even better. Maybe move driver stuff to sr_driver.c >>>and leave device stuff in smartreflex.c? I don't care much about the >>>names at this point. > > Quick question.. If we are going to separate out smartreflex device > portions from this file , can't we keep them in devices.c instead of > going for a separate file? Ultimately, that's Tony's call, but I would prefer to see a separate specific file for SR device init. Kevin