public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Remove duplicate Kconfig LEDS_LP5521 entry introduced by 67a32ec7
@ 2009-06-24  8:59 Arnaud Ebalard
  2009-06-24  8:59 ` Felipe Balbi
  0 siblings, 1 reply; 3+ messages in thread
From: Arnaud Ebalard @ 2009-06-24  8:59 UTC (permalink / raw)
  To: linux-omap@vger.kernel.org; +Cc: Tony Lindgren, Felipe Balbi

Hi,

While playing with kernel configuration for my N810, I noticed a
duplicate config entry for LEDS_LP5521.

AFAICT, it was added by commit 67a32ec7 (leds: introduce lp5521 led
driver) but the entry was already there from 43350bf4 (leds: lp5521:
move to drivers/leds).

Following patch is against current linux-omap tree.

Cheers,

a+

Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
---
 drivers/leds/Kconfig |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 788f48c..0493c17 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -170,16 +170,6 @@ config LEDS_LP5521
 	  This driver can be built as a module by choosing 'M'. The module
 	  will be called leds-lp5521.
 
-config LEDS_LP5521
-	tristate "LED Support for the LP5521 LEDs"
-	depends on LEDS_CLASS && I2C
-	help
-	  If you say 'Y' here you get support for the National Semiconductor
-	  LP5521 LED driver used in n8x0 boards.
-
-	  This driver can be built as a module by choosing 'M'. The module
-	  will be called leds-lp5521.
-
 config LEDS_CLEVO_MAIL
 	tristate "Mail LED on Clevo notebook"
 	depends on LEDS_CLASS && X86 && SERIO_I8042 && DMI
-- 
1.6.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove duplicate Kconfig LEDS_LP5521 entry introduced by 67a32ec7
  2009-06-24  8:59 [PATCH] Remove duplicate Kconfig LEDS_LP5521 entry introduced by 67a32ec7 Arnaud Ebalard
@ 2009-06-24  8:59 ` Felipe Balbi
  2009-06-24 10:42   ` Arnaud Ebalard
  0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2009-06-24  8:59 UTC (permalink / raw)
  To: ext Arnaud Ebalard
  Cc: linux-omap@vger.kernel.org, Tony Lindgren,
	Balbi Felipe (Nokia-D/Helsinki)

On Wed, Jun 24, 2009 at 10:59:06AM +0200, ext Arnaud Ebalard wrote:
> Hi,
> 
> While playing with kernel configuration for my N810, I noticed a
> duplicate config entry for LEDS_LP5521.
> 
> AFAICT, it was added by commit 67a32ec7 (leds: introduce lp5521 led
> driver) but the entry was already there from 43350bf4 (leds: lp5521:
> move to drivers/leds).
> 
> Following patch is against current linux-omap tree.

probably automerge issues.

-- 
balbi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove duplicate Kconfig LEDS_LP5521 entry introduced by 67a32ec7
  2009-06-24  8:59 ` Felipe Balbi
@ 2009-06-24 10:42   ` Arnaud Ebalard
  0 siblings, 0 replies; 3+ messages in thread
From: Arnaud Ebalard @ 2009-06-24 10:42 UTC (permalink / raw)
  To: felipe.balbi; +Cc: linux-omap@vger.kernel.org, Tony Lindgren

Hi Felipe,

Felipe Balbi <felipe.balbi@nokia.com> writes:

> On Wed, Jun 24, 2009 at 10:59:06AM +0200, ext Arnaud Ebalard wrote:
>> Hi,
>> 
>> While playing with kernel configuration for my N810, I noticed a
>> duplicate config entry for LEDS_LP5521.
>> 
>> AFAICT, it was added by commit 67a32ec7 (leds: introduce lp5521 led
>> driver) but the entry was already there from 43350bf4 (leds: lp5521:
>> move to drivers/leds).
>> 
>> Following patch is against current linux-omap tree.
>
> probably automerge issues.

I have no clue on how it happened. After noticing the duplication, I
just did a git annotate to get some info and then took a look at
associated patches.

Cheers,

a+

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-06-24 10:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-24  8:59 [PATCH] Remove duplicate Kconfig LEDS_LP5521 entry introduced by 67a32ec7 Arnaud Ebalard
2009-06-24  8:59 ` Felipe Balbi
2009-06-24 10:42   ` Arnaud Ebalard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox