From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue Date: Thu, 18 Jun 2009 07:11:51 -0700 Message-ID: <87ab45vdg8.fsf@deeprootsystems.com> References: <87vdmuyhxc.fsf@deeprootsystems.com> <20090618052710.GB8482@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from wf-out-1314.google.com ([209.85.200.168]:1429 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbZFROLv (ORCPT ); Thu, 18 Jun 2009 10:11:51 -0400 Received: by wf-out-1314.google.com with SMTP id 26so553193wfd.4 for ; Thu, 18 Jun 2009 07:11:53 -0700 (PDT) In-Reply-To: <20090618052710.GB8482@atomide.com> (Tony Lindgren's message of "Thu\, 18 Jun 2009 08\:27\:12 +0300") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: "Pandita, Vikram" , "linux-omap@vger.kernel.org" Tony Lindgren writes: > * Pandita, Vikram [090617 19:26]: >> >> >> >-----Original Message----- >> >From: Kevin Hilman [mailto:khilman@deeprootsystems.com] >> >Sent: Wednesday, June 17, 2009 10:55 AM >> >To: Tony Lindgren; Pandita, Vikram >> >Cc: linux-omap@vger.kernel.org >> >Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue >> > >> >Tony Lindgren writes: >> > >> >> This patch has been applied to the linux-omap >> >> by youw fwiendly patch wobot. >> >> >> >> Branch in linux-omap: omap-fixes >> >> >> >> Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954 >> >> >> >> PatchWorks >> >> http://patchwork.kernel.org/patch/29668/ >> >> >> >> Git (Likely to change, and takes a while to get mirrored) >> >> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap- >> >2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954 >> > >> >Sorry, I didn't get to this beforethe merge, but $SUBJECT for this >> >patch is wrong and not terribly helpful. It refers to the symptom, bu >> >tnot the root cause. >> > >> >It should be something like: >> > >> >OMAP3: Zoom2: pass IRQ triggering flags for serial driver >> >> Yes that should have been the subject and >> is put that way for the 8250 driver: >> http://lists.arm.linux.org.uk/lurker/attach/1@20090612.173251.776f9eda.attach >> >> It's learning for next time. > > Will revert. I guess we now need two 8250 patches upstream? One for the > omap register define, and one for the interrupt flags? Yes, both of these are pending on LKML, and still no word from Alan. To get it upstream, I defined wake-up register locally in mach-omap2/serial.c until the patch gets merged, but for the interrupt flags there isn't an easy solution. Kevin