[PATCH 00/08] OMAP3: SR: Fixes in Smartreflex driver - Resending

[PATCH 00/08] OMAP3: SR: Fixes in Smartreflex driver - Resending

[Reddy, Teerth]

Hi,

Resending the patches sent by Rajendra after fixing Kevin's comments and cleanup.

This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now functional and is validated with these patches on a ES3.1 based SDP with the N values in Efuse.

Patches apply on top of the pm-2.6.28 branch from Kevin's pm tree.
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git 

regards,
Rajendra--

Re: [PATCH 00/08] OMAP3: SR: Fixes in Smartreflex driver - Resending

[Kevin Hilman]

"Reddy, Teerth" <teerth@ti.com> writes:

> Resending the patches sent by Rajendra after fixing Kevin's comments and cleanup.
>
> This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now functional and is validated with these patches on a ES3.1 based SDP with the N values in Efuse.
>
> Patches apply on top of the pm-2.6.28 branch from Kevin's pm tree.
> git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git 
>

This series doesn't compile unless SRF is enabled which after a little
more digging makes me see that SmartReflex is not pretty tightly
coupled to SRF. 

I don't think SmartReflex support need to be dependent on SRF?  It
seems like the resource_get_level() calls should be replaced by OMAP
PM layer calls.  In particular, resource_get_level("vdd_opp1") could
be replaced by omap_pm_dsp_get_opp() etc.

Also, one more nitpick about cleanup while we're at it:

Can you convert all the bit defines (0x1 << n) into BIT(n)

Kevin