linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: Abhilash K V <abhilash.kv@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, tony@atomide.com,
	linux@arm.linux.org.uk, Vaibhav Hiremath <hvaibhav@ti.com>
Subject: Re: [PATCH 3/4] pm34xx: Warning FIX related to ambiguous else loop
Date: Tue, 30 Aug 2011 16:00:39 -0700	[thread overview]
Message-ID: <87bov6ld2g.fsf@ti.com> (raw)
In-Reply-To: <1313754927-11992-4-git-send-email-abhilash.kv@ti.com> (Abhilash K. V.'s message of "Fri, 19 Aug 2011 17:25:26 +0530")

Abhilash K V <abhilash.kv@ti.com> writes:

> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
> Fixes below warning -
>
> arch/arm/mach-omap2/pm34xx.c:1041: warning:
>         suggest explicit braces to avoid ambiguous 'else

This warning was introduced in [1/4], so I'd suggest just folding this
fix into the original patch.

Kevin

> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Signed-off-by: Abhilash K V <abhilash.kv@ti.com>
> ---
>  arch/arm/mach-omap2/pm34xx.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 12af5b9..ab3822b 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -856,7 +856,7 @@ void omap_push_sram_idle(void)
>  	else
>  		_omap_sram_idle = omap_sram_push(omap34xx_cpu_suspend,
>  					omap34xx_cpu_suspend_sz);
> -	if (omap_type() != OMAP2_DEVICE_TYPE_GP)
> +	if (omap_type() != OMAP2_DEVICE_TYPE_GP) {
>  		if (cpu_is_omap3505() || cpu_is_omap3517())
>  			_omap_save_secure_sram = omap_sram_push(
>  					omap3517_save_secure_ram_context,
> @@ -865,6 +865,7 @@ void omap_push_sram_idle(void)
>  			_omap_save_secure_sram = omap_sram_push(
>  					save_secure_ram_context,
>  					save_secure_ram_context_sz);
> +	}
>  }
>  
>  static void __init pm_errata_configure(void)

  parent reply	other threads:[~2011-08-30 23:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19 11:55 [PATCH 0/4] AM3517: Adding support for suspend/resume Abhilash K V
2011-08-19 11:55 ` [PATCH 1/4] AM3517 : " Abhilash K V
2011-08-19 11:55   ` [PATCH 2/4] AM3517: Add armv7-a flag for sleepam3517.S Abhilash K V
2011-08-19 11:55     ` [PATCH 3/4] pm34xx: Warning FIX related to ambiguous else loop Abhilash K V
2011-08-19 11:55       ` [PATCH 4/4] AM3517: Fix suspend-resume sequence Abhilash K V
2011-08-19 19:53         ` Russell King - ARM Linux
2011-08-30 23:00       ` Kevin Hilman [this message]
2011-08-19 19:56   ` [PATCH 1/4] AM3517 : support for suspend/resume Russell King - ARM Linux
2011-08-30 22:58   ` Kevin Hilman
2011-09-13 11:31     ` Koyamangalath, Abhilash
2011-09-13 18:24       ` Kevin Hilman
2011-09-14 13:00         ` Koyamangalath, Abhilash
2011-09-15 17:09           ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bov6ld2g.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=abhilash.kv@ti.com \
    --cc=hvaibhav@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).