[PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx headers

[PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx headers

[Hari Kanigeri]

The prm-regbits-xxxx.h header files are not dependent on prm.h
header file.

Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    1 +
 arch/arm/mach-omap2/prm-regbits-24xx.h     |    1 -
 arch/arm/mach-omap2/prm-regbits-34xx.h     |    1 -
 arch/arm/mach-omap2/prm-regbits-44xx.h     |    1 -
 4 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 667633c..88cc9ca 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -26,6 +26,7 @@
 #include "omap_hwmod_common_data.h"
 
 #include "cm.h"
+#include "prm.h"
 #include "prm-regbits-44xx.h"
 
 /* Base offset for all OMAP4 interrupts external to MPUSS */
diff --git a/arch/arm/mach-omap2/prm-regbits-24xx.h b/arch/arm/mach-omap2/prm-regbits-24xx.h
index 4002051..fd763b5 100644
--- a/arch/arm/mach-omap2/prm-regbits-24xx.h
+++ b/arch/arm/mach-omap2/prm-regbits-24xx.h
@@ -14,7 +14,6 @@
  * published by the Free Software Foundation.
  */
 
-#include "prm.h"
 
 /* Bits shared between registers */
 
diff --git a/arch/arm/mach-omap2/prm-regbits-34xx.h b/arch/arm/mach-omap2/prm-regbits-34xx.h
index 8f21bae..ef7fd5e 100644
--- a/arch/arm/mach-omap2/prm-regbits-34xx.h
+++ b/arch/arm/mach-omap2/prm-regbits-34xx.h
@@ -14,7 +14,6 @@
  * published by the Free Software Foundation.
  */
 
-#include "prm.h"
 
 /* Shared register bits */
 
diff --git a/arch/arm/mach-omap2/prm-regbits-44xx.h b/arch/arm/mach-omap2/prm-regbits-44xx.h
index 597be4a..ef7af7e 100644
--- a/arch/arm/mach-omap2/prm-regbits-44xx.h
+++ b/arch/arm/mach-omap2/prm-regbits-44xx.h
@@ -22,7 +22,6 @@
 #ifndef __ARCH_ARM_MACH_OMAP2_PRM_REGBITS_44XX_H
 #define __ARCH_ARM_MACH_OMAP2_PRM_REGBITS_44XX_H
 
-#include "prm.h"
 
 
 /*
-- 
1.7.0

Re: [PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx headers

[Kevin Hilman]

Hari Kanigeri <h-kanigeri2@ti.com> writes:

> The prm-regbits-xxxx.h header files are not dependent on prm.h
> header file.
>
> Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    1 +

This file is not in mailine, or linux-omap master.  Please
state any dependencies in this part of the changelog.

Kevin

>  arch/arm/mach-omap2/prm-regbits-24xx.h     |    1 -
>  arch/arm/mach-omap2/prm-regbits-34xx.h     |    1 -
>  arch/arm/mach-omap2/prm-regbits-44xx.h     |    1 -
>  4 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 667633c..88cc9ca 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -26,6 +26,7 @@
>  #include "omap_hwmod_common_data.h"
>  
>  #include "cm.h"
> +#include "prm.h"
>  #include "prm-regbits-44xx.h"
>  
>  /* Base offset for all OMAP4 interrupts external to MPUSS */
> diff --git a/arch/arm/mach-omap2/prm-regbits-24xx.h b/arch/arm/mach-omap2/prm-regbits-24xx.h
> index 4002051..fd763b5 100644
> --- a/arch/arm/mach-omap2/prm-regbits-24xx.h
> +++ b/arch/arm/mach-omap2/prm-regbits-24xx.h
> @@ -14,7 +14,6 @@
>   * published by the Free Software Foundation.
>   */
>  
> -#include "prm.h"
>  
>  /* Bits shared between registers */
>  
> diff --git a/arch/arm/mach-omap2/prm-regbits-34xx.h b/arch/arm/mach-omap2/prm-regbits-34xx.h
> index 8f21bae..ef7fd5e 100644
> --- a/arch/arm/mach-omap2/prm-regbits-34xx.h
> +++ b/arch/arm/mach-omap2/prm-regbits-34xx.h
> @@ -14,7 +14,6 @@
>   * published by the Free Software Foundation.
>   */
>  
> -#include "prm.h"
>  
>  /* Shared register bits */
>  
> diff --git a/arch/arm/mach-omap2/prm-regbits-44xx.h b/arch/arm/mach-omap2/prm-regbits-44xx.h
> index 597be4a..ef7af7e 100644
> --- a/arch/arm/mach-omap2/prm-regbits-44xx.h
> +++ b/arch/arm/mach-omap2/prm-regbits-44xx.h
> @@ -22,7 +22,6 @@
>  #ifndef __ARCH_ARM_MACH_OMAP2_PRM_REGBITS_44XX_H
>  #define __ARCH_ARM_MACH_OMAP2_PRM_REGBITS_44XX_H
>  
> -#include "prm.h"
>  
>  
>  /*
> -- 
> 1.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx headers

[Kanigeri, Hari]

Hi Kevin

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Thursday, May 20, 2010 12:13 PM
> To: Kanigeri, Hari
> Cc: Paul Walmsley; Linux Omap
> Subject: Re: [PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx
> headers
> 
> Hari Kanigeri <h-kanigeri2@ti.com> writes:
> 
> > The prm-regbits-xxxx.h header files are not dependent on prm.h
> > header file.
> >
> > Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
> > ---
> >  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    1 +
> 
> This file is not in mailine, or linux-omap master.  Please
> state any dependencies in this part of the changelog.
> 

This is based on the latest omap4_next branch on dev.omapzoom.org, so most probably didn't make it to linux omap yet.

I came to know through Benoit that this file is auto-generated using Perl script, so I guess this change can be handled in the generator script.

Thank you,
Best regards,
Hari

Re: [PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx headers

[Benoit Cousson]

On 5/20/2010 8:25 PM, Kanigeri, Hari wrote:
> Hi Kevin
>
>> -----Original Message-----
>> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
>> Sent: Thursday, May 20, 2010 12:13 PM
>> To: Kanigeri, Hari
>> Cc: Paul Walmsley; Linux Omap
>> Subject: Re: [PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx
>> headers
>>
>> Hari Kanigeri<h-kanigeri2@ti.com>  writes:
>>
>>> The prm-regbits-xxxx.h header files are not dependent on prm.h
>>> header file.
>>>
>>> Signed-off-by: Hari Kanigeri<h-kanigeri2@ti.com>
>>> ---
>>>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    1 +
>>
>> This file is not in mailine, or linux-omap master.  Please
>> state any dependencies in this part of the changelog.
>>
>
> This is based on the latest omap4_next branch on dev.omapzoom.org, so most probably didn't make it to linux omap yet.

These patches were posted recently as well, so you can refer to them, 
but then your patch might get stuck in a wip branch.

> I came to know through Benoit that this file is auto-generated using Perl script, so I guess this change can be handled in the generator script.

In fact, it is Python scripts... I hate Perl (special note for Nishanth 
M :-))
But yes, I can take care of the change, and then your patch will not 
have any dependency with the omap4 hwmod data patches and can be 
potentially accepted sooner.

Benoit

>
> Thank you,
> Best regards,
> Hari
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html