Re: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build

[Kevin Hilman <khilman@deeprootsystems.com>]

"G, Manjunath Kondaiah" <manjugk@ti.com> writes:

>> > diff --git a/arch/arm/mach-omap2/pm-debug.c 
>> b/arch/arm/mach-omap2/pm-debug.c
>> > index 767ebbc..3a42615 100644
>> > --- a/arch/arm/mach-omap2/pm-debug.c
>> > +++ b/arch/arm/mach-omap2/pm-debug.c
>> > @@ -625,4 +625,6 @@ arch_initcall(pm_dbg_init);
>> >
>> >  #else
>> >  void pm_dbg_update_time(struct powerdomain *pwrdm, int prev) {}
>> > +int pm_dbg_regset_init(int reg_set) {}
>> > +int pm_dbg_regset_save(int reg_set) {}
>> 
>> you'll get compiler warnings from these.
>
> Can be changed to return with value zero for these API's.
>
>> 
>> >  #endif
>> 
>> but even there, this should be fixed in pm.h.  The current PM branch
>> has these defines already:
>> 
>> #define pm_dbg_regset_save(reg_set) do {} while (0);
>> #define pm_dbg_regset_init(reg_set) do {} while (0);
>> 
>> It would be cleaner to fix the #ifdef there to handle the
>> !CONFIG_DEBUG_FS case.
>
> pm branch has else condition for CONFIG_PM_DEBUG. But, CONFIG_DEBUG_FS
> is not handled. 

I know, my proposal is to handle the DEBUG_FS case there also.

> As there is already similar API - pm_dbg_update_time in pm_debug.c,
> these API's can also fit there. More over, using !CONFIG_DEBUG_FS
> will add some #ifdef's in header.

So handle the pm_dbg_update_time() in the header as well.

Handling them in the header will also eliminate the runtime overhead
of an empty function call when DEBUG_FS is not included.

Kevin
<