From: Kevin Hilman <khilman@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Grant Likely <grant.likely@linaro.org>,
Jon Hunter <jgchunter@gmail.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Tony Lindgren <tony@atomide.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
Florian Vaussard <florian.vaussard@epfl.ch>,
Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 1/1] gpio/omap: fix build error when OF_GPIO is not defined.
Date: Tue, 02 Jul 2013 13:48:49 -0700 [thread overview]
Message-ID: <87d2r0lmby.fsf@linaro.org> (raw)
In-Reply-To: <CACRpkdb3n6BKswq=ODXdByRJL3y+ezYF3ZS=nG2K=7Tn=amM9w@mail.gmail.com> (Linus Walleij's message of "Tue, 2 Jul 2013 22:15:37 +0200")
Linus Walleij <linus.walleij@linaro.org> writes:
> On Tue, Jul 2, 2013 at 9:46 PM, Javier Martinez Canillas
> <javier.martinez@collabora.co.uk> wrote:
>
>> The OMAP GPIO driver check if the chip has an associated
>> Device Tree node using the struct gpio_chip of_node member.
>>
>> But this is only build if CONFIG_OF_GPIO is defined which
>> leads to the following error when using omap1_defconfig:
>>
>> linux/drivers/gpio/gpio-omap.c: In function 'omap_gpio_chip_init':
>> linux/drivers/gpio/gpio-omap.c:1080:17: error: 'struct gpio_chip' has no member named 'of_node'
>> linux/drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_map':
>> linux/drivers/gpio/gpio-omap.c:1116:16: error: 'struct gpio_chip' has no member named 'of_node'
>>
>> Reported-by: Kevin Hilman <khilman@linaro.org>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>>
>> Hi Linus,
>>
>> Sorry for not spoting this issue before. In a previous version of the patch-set:
>>
>> [PATCH v3 0/2]: auto request GPIO as input if used as IRQ via DT
>>
>> of_have_populated_dt() was used instead of struct gpio_chip of_node member to
>> check wether legacy or DT boot was used. I did a build test on every OMAP platform
>> but later I was asked to use .of_node instead of_have_populated_dt() and forget
>> to do a built test for OMAP1.
>
> Such things happen ...
>
>> I hope this patch can go as a fix for the v3.11-rc cycle.
>
> Yeah I queued it on top of the others. Good thing I didn't rush the
> other two out :-)
I can confirm this makes the build work again for omap1_defconfig.
Javier, thanks for the quick fix!
Acked-by: Kevin Hilman <khilman@linaro.org>
Kevin
prev parent reply other threads:[~2013-07-02 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 19:46 [PATCH 1/1] gpio/omap: fix build error when OF_GPIO is not defined Javier Martinez Canillas
2013-07-02 20:15 ` Linus Walleij
2013-07-02 20:48 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2r0lmby.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=aaro.koskinen@iki.fi \
--cc=eballetbo@gmail.com \
--cc=florian.vaussard@epfl.ch \
--cc=grant.likely@linaro.org \
--cc=javier.martinez@collabora.co.uk \
--cc=jgchunter@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).