From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage() Date: Tue, 02 Oct 2012 14:37:35 -0700 Message-ID: <87d3108sio.fsf@deeprootsystems.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:39683 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756582Ab2JBVhf (ORCPT ); Tue, 2 Oct 2012 17:37:35 -0400 Received: by pbbrr4 with SMTP id rr4so9172400pbb.19 for ; Tue, 02 Oct 2012 14:37:35 -0700 (PDT) In-Reply-To: (Jean Pihet's message of "Fri, 28 Sep 2012 12:42:12 +0200") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jean Pihet Cc: Wei Yongjun , tony@atomide.com, linux@arm.linux.org.uk, yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Jean Pihet writes: > On Thu, Sep 27, 2012 at 7:54 AM, Wei Yongjun wrote: >> From: Wei Yongjun >> >> In case of error, the function voltdm_lookup() returns NULL >> not ERR_PTR(). The IS_ERR() test in the return value check >> should be replaced with NULL test. >> >> dpatch engine is used to auto generate this patch. >> (https://github.com/weiyj/dpatch) >> >> Signed-off-by: Wei Yongjun >> --- >> arch/arm/mach-omap2/pm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c >> index 9cb5ced..ab15e5c 100644 >> --- a/arch/arm/mach-omap2/pm.c >> +++ b/arch/arm/mach-omap2/pm.c >> @@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, >> } >> >> voltdm = voltdm_lookup(vdd_name); >> - if (IS_ERR(voltdm)) { >> + if (!voltdm) { >> pr_err("%s: unable to get vdd pointer for vdd_%s\n", >> __func__, vdd_name); >> goto exit; > > This looks good, so here is the ack: > Acked-by: Jean Pihet Thanks, queuing this one for v3.7-rc. Kevin