From: Kevin Hilman <khilman@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
paul@pwsan.com, archit@ti.com, neilb@suse.de,
jean.pihet@newoldbits.com, jw@terrafix.co.uk
Subject: Re: [PATCH 3/3] OMAPDSS: use sync versions of pm_runtime_put
Date: Mon, 23 Jan 2012 14:33:51 -0800 [thread overview]
Message-ID: <87d3aakq0g.fsf@ti.com> (raw)
In-Reply-To: <1327320930-14550-4-git-send-email-tomi.valkeinen@ti.com> (Tomi Valkeinen's message of "Mon, 23 Jan 2012 14:15:30 +0200")
Tomi Valkeinen <tomi.valkeinen@ti.com> writes:
> omapdss doesn't work properly on system suspend. The problem seems to be
> the fact that omapdss uses pm_runtime_put() functions when turning off
> the hardware, and when system suspend is in process only sync versions
> are allowed.
>
> Using non-sync versions normally and sync versions when suspending would
> need rather ugly hacks to convey the information of
> suspending/not-suspending to different functions. Optimally the driver
> wouldn't even need to care about this, and the PM layer would handle
> syncing when suspend is in process.
>
> This patch changes all omapdss's pm_runtime_put calls to
> pm_runtime_put_sync. This fixes the suspend problem, and probably the
> performance penalty of always using sync versions is negligible.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Kevin Hilman <khilman@ti.com>
next prev parent reply other threads:[~2012-01-23 22:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 12:15 [PATCH 0/3] OMAP: DSS PM fixes Tomi Valkeinen
2012-01-23 12:15 ` [PATCH 1/3] ARM: OMAP: HWMOD: split omap2/3 dispc hwmod class Tomi Valkeinen
2012-01-25 19:02 ` Paul Walmsley
2012-01-23 12:15 ` [PATCH 2/3] ARM: OMAP3: HWMOD: add SYSC_HAS_ENAWAKEUP for dispc Tomi Valkeinen
2012-01-25 19:02 ` Paul Walmsley
2012-01-23 12:15 ` [PATCH 3/3] OMAPDSS: use sync versions of pm_runtime_put Tomi Valkeinen
2012-01-23 22:33 ` Kevin Hilman [this message]
2012-01-25 8:04 ` [PATCH 0/3] OMAP: DSS PM fixes Tomi Valkeinen
2012-01-25 18:55 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3aakq0g.fsf@ti.com \
--to=khilman@ti.com \
--cc=archit@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=jw@terrafix.co.uk \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=neilb@suse.de \
--cc=paul@pwsan.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox