From: Kevin Hilman <khilman@ti.com>
To: "Kadiyala, Kishore" <kishore.kadiyala@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
tony@atomide.com, cjb@laptop.org, madhu.cr@ti.com,
paul@pwsan.com
Subject: Re: [PATCH 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework
Date: Thu, 10 Feb 2011 13:10:39 -0800 [thread overview]
Message-ID: <87d3mzioj4.fsf@ti.com> (raw)
In-Reply-To: <AANLkTimN68yMC6BxHOvsJSu_Ddw8Lxr9oxzpx3vy7gxP@mail.gmail.com> (Kishore Kadiyala's message of "Thu, 10 Feb 2011 22:38:16 +0530")
"Kadiyala, Kishore" <kishore.kadiyala@ti.com> writes:
[...]
>
>>
>> The board code should simply call some mmc init routine optionally
>> passing int the platform_data, just like is done for hsmmc_init.
>>
>> With common hwmod data, shouldn't it be possible to unify the init of
>> MMC and HS-MMC controllers?
>
> The init of MMC & HS-MMC are different.
> HSMMC supported boards, the board file fills an intermediate structure
> omap2_hsmmc_info which is used by the hsmmc.c file to update the
> omap_mmc_platform_data.
>
> MMC supported boards, the board file fills the omap_mmc_platform_data.
Yes, I understand how they are different _today_. My question is that
now that we're using hwmod, is there any real reason they need to remain
different.
>
> Ok, will try to keep an API common for init of both MMC & HSMMC
>
Thanks,
Kevin
prev parent reply other threads:[~2011-02-10 21:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 15:27 [PATCH 0/5] OMAP: HSMMC: hwmod adaptation Kishore Kadiyala
2011-02-02 15:27 ` [PATCH 1/5] OMAP2420: hwmod data: Add HSMMC Kishore Kadiyala
2011-02-08 22:36 ` Kevin Hilman
2011-02-10 17:02 ` Kadiyala, Kishore
2011-02-08 23:29 ` Paul Walmsley
2011-02-10 17:07 ` Kadiyala, Kishore
2011-02-10 19:52 ` Paul Walmsley
2011-02-02 15:27 ` [PATCH 2/5] OMAP2430: " Kishore Kadiyala
2011-02-02 15:27 ` [PATCH 3/5] OMAP3: " Kishore Kadiyala
2011-02-08 22:30 ` Kevin Hilman
2011-02-10 17:02 ` Kadiyala, Kishore
2011-02-02 15:27 ` [PATCH 4/5] OMAP4: " Kishore Kadiyala
2011-02-02 15:27 ` [PATCH 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework Kishore Kadiyala
2011-02-08 23:05 ` Kevin Hilman
2011-02-10 17:08 ` Kadiyala, Kishore
2011-02-10 21:10 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3mzioj4.fsf@ti.com \
--to=khilman@ti.com \
--cc=cjb@laptop.org \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).