From: Kevin Hilman <khilman@deeprootsystems.com>
To: Vishwanath Sripathy <vishwanath.bs@ti.com>
Cc: Benoit Cousson <b-cousson@ti.com>, Thara Gopinath <thara@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
paul@pwsan.com, Anand Sawant <sawant@ti.com>,
Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v5 4/5] OMAP4: hwmod: Add inital data for smartreflex modules.
Date: Thu, 23 Dec 2010 09:15:10 -0800 [thread overview]
Message-ID: <87d3osl8bl.fsf@deeprootsystems.com> (raw)
In-Reply-To: <a58103fd01d89decba08fcdf282b7f70@mail.gmail.com> (Vishwanath Sripathy's message of "Thu, 23 Dec 2010 20:58:26 +0530")
Vishwanath Sripathy <vishwanath.bs@ti.com> writes:
[...]
>>
>> Please note the following log when enabling SR in Class 3 on an
>> OMAP4430/sdp:
>>
>> [ 2.362182] omap2_set_init_voltage: unable to find boot up OPP for
>> vdd_mpu
>> [ 2.369384] omap2_set_init_voltage: Unable to put vdd_mpu to its init
>> voltage
>> [ 2.369384]
>> [ 2.378875] omap2_set_init_voltage: unable to find boot up OPP for
>> vdd_iva
>> [ 2.386108] omap2_set_init_voltage: Unable to put vdd_iva to its init
>> voltage
>> [ 2.386108]
>> [ 2.396484] Power Management for TI OMAP4.
>> [ 2.401031] sr_init: No PMIC hook to init smartreflex
>> [ 2.406494] smartreflex smartreflex.0: omap_sr_probe: SmartReflex
>> driver initialized
>> [ 2.414825] smartreflex smartreflex.1: omap_sr_probe: SmartReflex
>> driver initialized
>> [ 2.423187] smartreflex smartreflex.2: omap_sr_probe: SmartReflex
>> driver initialized
>> [ 2.431732] SmartReflex Class3 initialized
>>
>> Is it expected?
>> Why do we have that blank line in-between?
>
> I think turbo OPPs are disabled by default in OPP table where as uboot is
> setting mpu and iva to turbo OPP. That's why you are getting this error.
That explains the MPU OPPs, but only raises more questions. On what
platforms was this tested? with *and* without turbo OPPs enabled? Does
the voltage layer properly initialized if the boot up OPP is not found,
and the initial voltage is not set?
> You should not get this error if you enable turbo opps in opp table.
You would still get missing boot up OPP for IVA, as there are currenly
no OMAP4 OPPs for IVA. Again, begging the question... how was this
tested.
Kevin
next prev parent reply other threads:[~2010-12-23 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 17:00 [PATCH v5 0/5] OMAP4: Smartreflex and Voltage layer support Thara Gopinath
2010-12-20 17:00 ` [PATCH v5 1/5] OMAP4: Register voltage PMIC parameters with the voltage layer Thara Gopinath
2010-12-20 17:00 ` [PATCH v5 2/5] OMAP4: Adding voltage driver support Thara Gopinath
2010-12-28 17:32 ` Anand Sawant
2010-12-20 17:00 ` [PATCH v5 3/5] OMAP4: PM: Program correct init voltages for scalable VDDs Thara Gopinath
2010-12-20 17:00 ` [PATCH v5 4/5] OMAP4: hwmod: Add inital data for smartreflex modules Thara Gopinath
2010-12-23 12:07 ` Cousson, Benoit
2010-12-23 13:25 ` Menon, Nishanth
2010-12-23 14:05 ` Cousson, Benoit
2010-12-23 15:28 ` Vishwanath Sripathy
2010-12-23 17:15 ` Kevin Hilman [this message]
2010-12-23 17:24 ` Nishanth Menon
2010-12-23 17:36 ` Vishwanath Sripathy
2010-12-23 18:06 ` Nishanth Menon
2010-12-20 17:00 ` [PATCH v5 5/5] OMAP4: Smartreflex framework extensions Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3osl8bl.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=sawant@ti.com \
--cc=thara@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox