From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [GIT PULL] for testing: OMAP hwmod driver conversions: watchdog, UART, i2c Date: Tue, 28 Sep 2010 14:35:49 -0700 Message-ID: <87d3rxblfu.fsf@deeprootsystems.com> References: <8762xpenf8.fsf@deeprootsystems.com> <20100928201844.GI3117@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:40493 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753872Ab0I1Vfw (ORCPT ); Tue, 28 Sep 2010 17:35:52 -0400 Received: by pvg2 with SMTP id 2so28636pvg.19 for ; Tue, 28 Sep 2010 14:35:51 -0700 (PDT) In-Reply-To: <20100928201844.GI3117@atomide.com> (Tony Lindgren's message of "Tue, 28 Sep 2010 13:18:44 -0700") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak , Tony Lindgren Cc: linux-omap@vger.kernel.org, Charulatha Varadarajan , "Govindraj R." Rajendra, Tony Lindgren writes: > * Kevin Hilman [100928 11:25]: >> Tony, >> >> The following pull request will bring hwmod driver conversions for >> watchdog, UART and i2c drivers. It is based on your omap-for-linus >> branch. >> >> The i2c driver is waiting for final signoff/ack from the upstream >> subsystem maintainers, but are otherwise ready to go for broader >> testing. After I get the final ack, I will update the branch for a >> final pull. >> >> In the meantime, I'd like to get them into l-o master (or omap-testing) >> for broader testing. > > Tried pulling it but I'm getting tons of these errors on omap2: > > WARNING: at arch/arm/mach-omap2/omap_hwmod.c:1237 _omap_hwmod_idle+0x28/0xd8() > omap_hwmod: i2c1: idle state can only be entered from enabled state > Modules linked in: > [] (unwind_backtrace+0x0/0xec) from [] (warn_slowpath_common+0x4c/0x64) > [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_fmt+0x2c/0x3c) > [] (warn_slowpath_fmt+0x2c/0x3c) from [] (_omap_hwmod_idle+0x28/0xd8) > [] (_omap_hwmod_idle+0x28/0xd8) from [] (omap_hwmod_idle+0x28/0x38) > [] (omap_hwmod_idle+0x28/0x38) from [] (omap_device_idle_hwmods+0x1c/0x34) > [] (omap_device_idle_hwmods+0x1c/0x34) from [] (_omap_device_deactivate+0x4c/0x154) > [] (_omap_device_deactivate+0x4c/0x154) from [] (omap_device_idle+0x44/0x64) > [] (omap_device_idle+0x44/0x64) from [] (omap_pm_runtime_suspend+0x2c/0x50) > [] (omap_pm_runtime_suspend+0x2c/0x50) from [] (__pm_runtime_suspend+0x210/0x36c) > [] (__pm_runtime_suspend+0x210/0x36c) from [] (pm_runtime_suspend+0x20/0x34) > [] (pm_runtime_suspend+0x20/0x34) from [] (pm_generic_runtime_idle+0x40/0x48) > [] (pm_generic_runtime_idle+0x40/0x48) from [] (__pm_runtime_idle+0x164/0x1a0) > [] (__pm_runtime_idle+0x164/0x1a0) from [] (pm_runtime_idle+0x1c/0x30) > [] (pm_runtime_idle+0x1c/0x30) from [] (driver_probe_device+0x168/0x188) > [] (driver_probe_device+0x168/0x188) from [] (__driver_attach+0x68/0x8c) > [] (__driver_attach+0x68/0x8c) from [] (bus_for_each_dev+0x44/0x74) > [] (bus_for_each_dev+0x44/0x74) from [] (bus_add_driver+0x104/0x294) > [] (bus_add_driver+0x104/0x294) from [] (driver_register+0xa8/0x130) > [] (driver_register+0xa8/0x130) from [] (do_one_initcall+0xc8/0x1a0) > [] (do_one_initcall+0xc8/0x1a0) from [] (kernel_init+0x14c/0x214) > [] (kernel_init+0x14c/0x214) from [] (kernel_thread_exit+0x0/0x8) > > This is with the omap2plus_defconfig and after editing cmdline to have console set > to ttyO2. > > Would be nice to have those fixed before we merge it. Rajendra, can you look into this on OMAP2? This is happening for Tony on both n8x0 and 2430sdp. >> Note this also depends on a handful of patches from my pm-backports >> branch, most of which you have picked into omap-testing, except for the >> one I just posted to linux-arm-kernel: >> >> ARM: add cpu_idle_wait() to support CPUidle on SMP systems. >> >> This one is required now that the default config enables SMP. > > I'll apply that into omap-testing branch. Thanks, Kevin