From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 00/10] OMAP3: SR: Fixes in Smartreflex driver Date: Wed, 22 Apr 2009 13:04:33 -0700 Message-ID: <87d4b4zc8e.fsf@deeprootsystems.com> References: <5A47E75E594F054BAF48C5E4FC4B92AB02FB25180A@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from wf-out-1314.google.com ([209.85.200.168]:45987 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbZDVUEg (ORCPT ); Wed, 22 Apr 2009 16:04:36 -0400 Received: by wf-out-1314.google.com with SMTP id 26so135798wfd.4 for ; Wed, 22 Apr 2009 13:04:36 -0700 (PDT) In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02FB25180A@dbde02.ent.ti.com> (Rajendra Nayak's message of "Wed\, 15 Apr 2009 18\:25\:05 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Nayak, Rajendra" Cc: linux-omap "Nayak, Rajendra" writes: > Re-sending this patch-set with some mailer issues resolved. They now apply cleanly > with a git-am/git-apply. > > Hi, > > This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now > functional and is validated with these patches on a ES3.1 based SDP with the N values in Efuse. > > The patches also make the Smartreflex driver independent of SRF by using the OMAP PM apis > instead of calls to SRF. > > Patches apply on top of the latest pm branch from Kevin's pm tree. > git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git Rajendra, This series seems to boot on SDP and Beagle but I recetly tried on RX51 and it hangs in omap3_sr_init(). Using Lauterbach, I tracked it to hang in sr_configure_vp() at this PRM write to the PRM_VP1_VLIMITTO register: prm_write_mod_reg(PRM_VP1_VLIMITTO_VDDMAX | PRM_VP1_VLIMITTO_VDDMIN | PRM_VP1_VLIMITTO_TIMEOUT, OMAP3430_GR_MOD, OMAP3_PRM_VP1_VLIMITTO_OFFSET); Should these min/max/timeout values be board specific? Kevin