public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Mans Rullgard <mans@mansr.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: Increase VMALLOC_END to allow 256MB RAM
Date: Thu, 02 Oct 2008 12:29:25 +0300	[thread overview]
Message-ID: <87d4ijwdje.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1222936611-19084-1-git-send-email-mans@mansr.com> (Mans Rullgard's message of "Thu\,  2 Oct 2008 09\:36\:51 +0100")

Mans Rullgard <mans@mansr.com> writes:

> This increases VMALLOC_END to 0x18000000, making room for 256MB
> RAM with the default 128MB vmalloc region.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
>  arch/arm/plat-omap/include/mach/vmalloc.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/mach/vmalloc.h b/arch/arm/plat-omap/include/mach/vmalloc.h
> index d8515cb..b97dfaf 100644
> --- a/arch/arm/plat-omap/include/mach/vmalloc.h
> +++ b/arch/arm/plat-omap/include/mach/vmalloc.h
> @@ -17,5 +17,5 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
>   */
> -#define VMALLOC_END	  (PAGE_OFFSET + 0x17000000)
> +#define VMALLOC_END	  (PAGE_OFFSET + 0x18000000)

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

I have a similar patch locally, but the problem I currently have with
it is that there is no longer any hole between vmalloc space and the
beginning of IO space (the first virtual mappings start at
0xd8000000.)

It's a bit unsafe, but IMO it's is probably OK for the short term.
Longer term I think the virtual address space of the OMAP kernels
needs to be reworked.  It currenly just maps directly onto the
physical address space, which makes the IO_ADDRESS() conversion macros
simple, but leaves lots of wasted space in the virtual address space.

Kevin




  reply	other threads:[~2008-10-02  9:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02  8:36 [PATCH] OMAP: Increase VMALLOC_END to allow 256MB RAM Mans Rullgard
2008-10-02  9:29 ` Kevin Hilman [this message]
2008-10-04  9:38   ` Koen Kooi
2008-10-06  7:16     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4ijwdje.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mans@mansr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox