From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: "Reizer, Eyal" <eyalr-l0cyMroinI0@public.gmane.org>,
Eyal Reizer <eyalreizer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-wireless@vger.kernel.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-omap@vger.kernel.org"
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [EXTERNAL] Re: [PATCH] wlcore: use generic runtime pm calls for wowlan elp configuration
Date: Thu, 24 May 2018 16:36:09 +0300 [thread overview]
Message-ID: <87efi1b2gm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180524132132.GZ98604-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> (Tony Lindgren's message of "Thu, 24 May 2018 06:21:32 -0700")
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> writes:
> * Reizer, Eyal <eyalr-l0cyMroinI0@public.gmane.org> [180524 08:20]:
>> >
>> > > With runtime PM enabled, we can now use generic calls to
>> > > pm_generic_runtime_suspend and pm_generic_runtime_resume for
>> > enabling elp
>> > > during suspend when wowlan is enabled and waking the chip from elp
>> > > on resume.
>> > > remove the custom API that was used to ensure that the command
>> > > that is used to allow ELP during suspend is completed before the system
>> > > suspend.
>> > >
>> > > Signed-off-by: Eyal Reizer <eyalr-l0cyMroinI0@public.gmane.org>
>> > > ---
>> > > Dependent on the Runtime PM support for wlcore patch set that was
>> > submitted
>> > > by Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>> >
>> > Ok, I'll drop this from my queue. Please resubmit once Tony's patches
>> > are ready to apply (or Tony can include this patch in his patchset).
>> >
>> > BTW, for me it would be a lot easier if you could mark patches like this
>> > as RFT (Request For Test) or RFC (Request For Comments). That way I can
>> > automatically drop the patch without sending any emails.
>
> Sorry for the noise, what seemed like a trivial change to use generic
> runtime PM exposed few unexpected issues :) I'll do one more revision
> of all the patches with RFT. Then when we are happy with that series,
> I'll do one more patch to enable runtime PM autosuspend support to
> avoid enabling and disabing the hardware constantly. And then after
> that we should have the patches finally ready for merging.
Sounds good to me, kiitos :)
--
Kalle Valo
prev parent reply other threads:[~2018-05-24 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 7:18 [PATCH] wlcore: use generic runtime pm calls for wowlan elp configuration Eyal Reizer
[not found] ` <1527146337-17562-1-git-send-email-eyalr-l0cyMroinI0@public.gmane.org>
2018-05-24 8:05 ` Kalle Valo
[not found] ` <87fu2hiilx.fsf-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-05-24 8:18 ` [EXTERNAL] " Reizer, Eyal
[not found] ` <06f0b1b5243a4ab7befad7b9109bf5a5-l0cyMroinI0@public.gmane.org>
2018-05-24 13:21 ` Tony Lindgren
[not found] ` <20180524132132.GZ98604-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-05-24 13:36 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efi1b2gm.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=eyalr-l0cyMroinI0@public.gmane.org \
--cc=eyalreizer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).