From: Kevin Hilman <khilman@linaro.org>
To: Andrii Tseglytskyi <andrii.tseglytskyi@ti.com>
Cc: J Keerthy <j-keerthy@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v1 1/3] PM / AVS: SmartReflex: disable errgen before vpbound disable
Date: Wed, 29 May 2013 09:32:50 -0700 [thread overview]
Message-ID: <87ehcp926l.fsf@linaro.org> (raw)
In-Reply-To: <51A60F86.4090900@ti.com> (Andrii Tseglytskyi's message of "Wed, 29 May 2013 17:24:06 +0300")
Andrii Tseglytskyi <andrii.tseglytskyi@ti.com> writes:
> On 05/29/2013 12:58 PM, Andrii Tseglytskyi wrote:
>> Hi Kevin,
>>
>> Thanks a lot for your comments.
>>
>> On 05/28/2013 09:45 PM, Kevin Hilman wrote:
>>> Andrii Tseglytskyi <andrii.tseglytskyi@ti.com> writes:
>>>
>>>> From: Nishanth Menon <nm@ti.com>
>>>>
>>>> vpboundsintr_en is available inside the IP block as an re-sycned
>>>> version and one which is not. Due to this, there is an 1 sysclk
>>>> cycle window where interruptz could be asserted low for 1 cycle.
>>> ^^^
>>>
>>> Is that the way the cool kidz are spelling interrupts these days? ;)
>>
>> Oh! Shame on me. Thank you for catching this :)
>
> Shame on me again (((. Name "interruptz" is more less OK. This is the
> name of signal between Voltage Processor and SmartReflex.
> In documentation it is referenced as "SR_SInterruptz". Anyway commit
> message should be updated to make this more clear.
Ah, OK. Makes sense now.
Yes, the changlog should be more clear that this is referring to a
signal name, e.g.
...there is an 1 sysclk cycle window where the SR_SInterruptz
signal could be asserted low.
(also note that I think the "for once cycle" that ends that phrase in
the original changelog is redundant, since it already says a "1 sysclk
cycle window".
Kevin
next prev parent reply other threads:[~2013-05-29 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 11:07 [PATCH v1 0/3] PM / AVS: SmartReflex: driver misc fixes Andrii Tseglytskyi
2013-05-27 11:07 ` [PATCH v1 1/3] PM / AVS: SmartReflex: disable errgen before vpbound disable Andrii Tseglytskyi
2013-05-28 18:45 ` Kevin Hilman
2013-05-29 9:58 ` Andrii Tseglytskyi
2013-05-29 14:01 ` Kevin Hilman
2013-05-29 14:24 ` Andrii Tseglytskyi
2013-05-29 16:32 ` Kevin Hilman [this message]
2013-05-27 11:07 ` [PATCH v1 2/3] PM / AVS: SmartReflex: disable runtime PM on driver remove Andrii Tseglytskyi
2013-05-27 11:07 ` [PATCH v1 3/3] PM / AVS: SmartReflex: fix driver name Andrii Tseglytskyi
2013-05-28 21:03 ` [PATCH v1 0/3] PM / AVS: SmartReflex: driver misc fixes Kevin Hilman
2013-05-29 10:00 ` Andrii Tseglytskyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehcp926l.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=andrii.tseglytskyi@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox