From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 5/6] ARM: OMAP4: suspend: Do not get dsp/tesla out of reset Date: Mon, 27 Feb 2012 16:28:04 -0800 Message-ID: <87ehtfssx7.fsf@ti.com> References: <1330003320-17400-1-git-send-email-t-kristo@ti.com> <1330003320-17400-6-git-send-email-t-kristo@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog112.obsmtp.com ([74.125.149.207]:52478 "EHLO na3sys009aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755577Ab2B1A2G (ORCPT ); Mon, 27 Feb 2012 19:28:06 -0500 Received: by mail-pz0-f42.google.com with SMTP id g27so5239013dan.15 for ; Mon, 27 Feb 2012 16:28:05 -0800 (PST) In-Reply-To: <1330003320-17400-6-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Thu, 23 Feb 2012 15:21:59 +0200") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tero Kristo Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rajendra Nayak Tero Kristo writes: > From: Rajendra Nayak > > With no driver handling DSP/TESLA, if brought out of reset, it stays > active and does not assert standby. > > Signed-off-by: Rajendra Nayak > Signed-off-by: Tero Kristo Subject says 'OMAP4: suspend'. How does HWMOD_INIT_NO_RESET affect suspend? Kevin > --- > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > index ef0524c..81d90da 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > @@ -1160,6 +1160,7 @@ static struct omap_hwmod omap44xx_dsp_hwmod = { > .name = "dsp", > .class = &omap44xx_dsp_hwmod_class, > .clkdm_name = "tesla_clkdm", > + .flags = HWMOD_INIT_NO_RESET, > .mpu_irqs = omap44xx_dsp_irqs, > .rst_lines = omap44xx_dsp_resets, > .rst_lines_cnt = ARRAY_SIZE(omap44xx_dsp_resets),