From: Kevin Hilman <khilman@ti.com>
To: "T Krishnamoorthy, Balaji" <balajitk@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
cjb@laptop.org, tony@atomide.com, madhu.cr@ti.com,
b-cousson@ti.com, adrian.hunter@nokia.com
Subject: Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support
Date: Tue, 28 Jun 2011 13:30:39 -0700 [thread overview]
Message-ID: <87ei2dy9zk.fsf@ti.com> (raw)
In-Reply-To: <BANLkTimT6nGP_ecJjZ6201=CiddN7BrsPg@mail.gmail.com> (T. Krishnamoorthy's message of "Tue, 28 Jun 2011 23:18:03 +0530")
"T Krishnamoorthy, Balaji" <balajitk@ti.com> writes:
> On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley <paul@pwsan.com> wrote:
>> (cc'ing Adrian also)
>>
>> Hi Balaji
>>
>> On Wed, 22 Jun 2011, Balaji T K wrote:
>>
>>> Use runtime autosuspend APIs to enable auto suspend delay
>>
>> Does this really need to use runtime autosuspend? Seems to me that since
>> PM runtime is just controlling the MMC IP blocks and not the regulators in
>> this instance, this could simply use pm_runtime_put*() and just avoid the
>> extra power wastage and complexity involved in autosuspend.
>>
>
> I have seen some instabilities if delay is very less, on some production boards.
> The previous implementation used 100ms delay before disabling the clocks.
And your new one is using 50ms. How did this value come about?
As Paul mentioned, the timeout value here is probably usecase depeend
Kevin
next prev parent reply other threads:[~2011-06-28 20:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 14:18 [PATCH 0/3] OMAP: HSMMC: cleanup and runtime pm Balaji T K
2011-06-22 14:18 ` [PATCH 1/3] MMC: OMAP: HSMMC: Remove lazy_disable Balaji T K
2011-06-22 18:26 ` Kevin Hilman
2011-06-23 12:31 ` T Krishnamoorthy, Balaji
2011-06-22 14:18 ` [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support Balaji T K
2011-06-22 18:38 ` Kevin Hilman
2011-06-23 12:31 ` T Krishnamoorthy, Balaji
2011-06-23 14:50 ` Kevin Hilman
2011-06-28 17:22 ` Paul Walmsley
2011-06-28 17:48 ` T Krishnamoorthy, Balaji
2011-06-28 18:41 ` Paul Walmsley
2011-06-29 14:17 ` T Krishnamoorthy, Balaji
2011-06-29 14:42 ` Paul Walmsley
2011-06-29 16:14 ` T Krishnamoorthy, Balaji
2011-06-29 19:04 ` Paul Walmsley
2011-06-29 15:38 ` Paul Walmsley
2011-06-29 16:34 ` S, Venkatraman
2011-06-29 20:07 ` Paul Walmsley
2011-06-30 5:20 ` S, Venkatraman
2011-06-28 20:30 ` Kevin Hilman [this message]
2011-06-29 14:33 ` T Krishnamoorthy, Balaji
2011-06-29 17:39 ` Kevin Hilman
2011-06-30 0:40 ` Paul Walmsley
2011-06-30 5:26 ` S, Venkatraman
2011-06-22 14:18 ` [PATCH 3/3] MMC: OMAP: HSMMC: Remove unused iclk Balaji T K
2011-06-22 16:27 ` Cousson, Benoit
2011-06-27 14:41 ` T Krishnamoorthy, Balaji
2011-06-22 16:05 ` [PATCH 0/3] OMAP: HSMMC: cleanup and runtime pm Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei2dy9zk.fsf@ti.com \
--to=khilman@ti.com \
--cc=adrian.hunter@nokia.com \
--cc=b-cousson@ti.com \
--cc=balajitk@ti.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox