From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 08/10] omap2+: Use dmtimer macros for clocksource Date: Thu, 23 Jun 2011 09:47:47 -0700 Message-ID: <87ei2kbiks.fsf@ti.com> References: <20110620091754.357.56441.stgit@kaulin> <20110620092345.357.11154.stgit@kaulin> <87iprwbm9p.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog115.obsmtp.com ([74.125.149.238]:42879 "EHLO na3sys009aog115.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759069Ab1FWQrv (ORCPT ); Thu, 23 Jun 2011 12:47:51 -0400 Received: by mail-pw0-f45.google.com with SMTP id 5so1398923pwi.4 for ; Thu, 23 Jun 2011 09:47:50 -0700 (PDT) In-Reply-To: <87iprwbm9p.fsf@ti.com> (Kevin Hilman's message of "Thu, 23 Jun 2011 08:28:02 -0700") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Kevin Hilman writes: > Tony Lindgren writes: > >> Use dmtimer macros for clocksource. As with the clockevent, >> this allows us to initialize the rest of dmtimer code later on. >> >> Note that eventually we will be initializing the timesource >> from init_early so sched_clock will work properly for >> CONFIG_PRINTK_TIME. >> >> Signed-off-by: Tony Lindgren >> Reviewed-by: Kevin Hilman > > [...] > >> +/* Setup free-running counter for clocksource */ >> +static void __init omap2_gp_clocksource_init(int gptimer_id, >> + const char *fck_source) >> +{ >> + int res; >> + >> + res = omap_dm_timer_init_one(&clksrc, gptimer_id, fck_source); >> + BUG_ON(res); > > This is a change from previous code where the clocksource was requesting > any timer, not a specific one. > > Also, you're using the same gptimer_id here as the clockevent, which > means this is guaranteed to fail. Nevermind, ignore this comment. I misread the macros. Sorry for the noise. Kevin