* [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF
@ 2011-03-08 15:09 Santosh Shilimkar
2011-03-08 23:22 ` Paul Walmsley
0 siblings, 1 reply; 4+ messages in thread
From: Santosh Shilimkar @ 2011-03-08 15:09 UTC (permalink / raw)
To: linux-omap; +Cc: Santosh Shilimkar, Rajendra Nayak, Paul Walmsley, Kevin Hilman
As per OMAP4430 TRM, the dynamic dependency between MEMIF and MPUSS
clockdomains is enable by default. Refer register CM_MPU_DYNAMICDEP
description for details.
But it doesn't seems to work as expected and MPUSS doesn't wakeup
from off-mode if the static dependency is not set between MPUSS and
EMIF clockdomains. i.e CM_MPU_STATICDEP.MEMIF_STATDEP = 0
The issue is under investigation with hardware team.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@ti.com>
---
Patch applies on top of OMAP4 PM series.
Relevant thread on this issue:
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg46173.html
arch/arm/mach-omap2/pm44xx.c | 21 +++++++++++++++++++++
1 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
index d4ad31e..877fb99 100644
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -198,6 +198,7 @@ void omap4_pm_off_mode_enable(int enable)
static int __init omap4_pm_init(void)
{
int ret;
+ struct clockdomain *emif_clkdm, *mpuss_clkdm;
if (!cpu_is_omap44xx())
return -ENODEV;
@@ -213,6 +214,26 @@ static int __init omap4_pm_init(void)
(void) clkdm_for_each(clkdms_setup, NULL);
+
+ /*
+ * FIXME: Remove the MPUSS <-> EMIF static dependency once the
+ * dynamic dependency issue is root-caused.
+ * The dynamic dependency between MEMIF and MPUSS doesn't seems to
+ * work as expected and MPUSS does not wakeup from off-mode if
+ * the static dependency is not set between them.
+ * i.e. CM_MPU_STATICDEP.MEMIF_STATDEP = 0
+ */
+ mpuss_clkdm = clkdm_lookup("mpuss_clkdm");
+ emif_clkdm = clkdm_lookup("l3_emif_clkdm");
+ if ((!mpuss_clkdm) || (!emif_clkdm))
+ goto err2;
+
+ ret = clkdm_add_wkdep(mpuss_clkdm, emif_clkdm);
+ if (ret) {
+ pr_err("Failed to add MPUSS <-> EMIF wakeup dependency\n");
+ goto err2;
+ }
+
ret = omap4_mpuss_init();
if (ret) {
pr_err("Failed to initialise OMAP4 MPUSS\n");
--
1.6.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF
2011-03-08 15:09 [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF Santosh Shilimkar
@ 2011-03-08 23:22 ` Paul Walmsley
2011-03-09 0:12 ` Kevin Hilman
0 siblings, 1 reply; 4+ messages in thread
From: Paul Walmsley @ 2011-03-08 23:22 UTC (permalink / raw)
To: Rajendra Nayak, Santosh Shilimkar, Kevin Hilman; +Cc: linux-omap
On Tue, 8 Mar 2011, Santosh Shilimkar wrote:
> As per OMAP4430 TRM, the dynamic dependency between MEMIF and MPUSS
> clockdomains is enable by default. Refer register CM_MPU_DYNAMICDEP
> description for details.
>
> But it doesn't seems to work as expected and MPUSS doesn't wakeup
> from off-mode if the static dependency is not set between MPUSS and
> EMIF clockdomains. i.e CM_MPU_STATICDEP.MEMIF_STATDEP = 0
>
> The issue is under investigation with hardware team.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Kevin Hilman <khilman@ti.com>
Nice work!
Kevin, you want to take this one?
My only comment is that it might be nice to add a pr_info("OMAP4
PM: Temporary static dependency added between EMIF and MPUSS");
in there to reduce the risk that the issue will be forgotten...
Acked-by: Paul Walmsley <paul@pwsan.com>
- Paul
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF
2011-03-08 23:22 ` Paul Walmsley
@ 2011-03-09 0:12 ` Kevin Hilman
2011-03-09 4:59 ` Santosh Shilimkar
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2011-03-09 0:12 UTC (permalink / raw)
To: Paul Walmsley; +Cc: Rajendra Nayak, Santosh Shilimkar, linux-omap
Paul Walmsley <paul@pwsan.com> writes:
> On Tue, 8 Mar 2011, Santosh Shilimkar wrote:
>
>> As per OMAP4430 TRM, the dynamic dependency between MEMIF and MPUSS
>> clockdomains is enable by default. Refer register CM_MPU_DYNAMICDEP
>> description for details.
>>
>> But it doesn't seems to work as expected and MPUSS doesn't wakeup
>> from off-mode if the static dependency is not set between MPUSS and
>> EMIF clockdomains. i.e CM_MPU_STATICDEP.MEMIF_STATDEP = 0
>>
>> The issue is under investigation with hardware team.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> Cc: Paul Walmsley <paul@pwsan.com>
>> Cc: Kevin Hilman <khilman@ti.com>
>
> Nice work!
>
> Kevin, you want to take this one?
Yup
> My only comment is that it might be nice to add a pr_info("OMAP4
> PM: Temporary static dependency added between EMIF and MPUSS");
> in there to reduce the risk that the issue will be forgotten...
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
Santosh,
Please update with the pr_info() as suggested by Paul, repost with
linux-arm-kernel in Cc, add Paul's ack and I'll queue for 2.6.39.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF
2011-03-09 0:12 ` Kevin Hilman
@ 2011-03-09 4:59 ` Santosh Shilimkar
0 siblings, 0 replies; 4+ messages in thread
From: Santosh Shilimkar @ 2011-03-09 4:59 UTC (permalink / raw)
To: Kevin Hilman, Paul Walmsley; +Cc: Rajendra Nayak, linux-omap
> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@ti.com]
> Sent: Wednesday, March 09, 2011 5:42 AM
> To: Paul Walmsley
> Cc: Rajendra Nayak; Santosh Shilimkar; linux-omap@vger.kernel.org
> Subject: Re: [PATCH] OMAP4: PM: Set static dependency between MPUSS
> and EMIF
>
> Paul Walmsley <paul@pwsan.com> writes:
>
> > On Tue, 8 Mar 2011, Santosh Shilimkar wrote:
> >
> >> As per OMAP4430 TRM, the dynamic dependency between MEMIF and
> MPUSS
> >> clockdomains is enable by default. Refer register
> CM_MPU_DYNAMICDEP
> >> description for details.
> >>
> >> But it doesn't seems to work as expected and MPUSS doesn't wakeup
> >> from off-mode if the static dependency is not set between MPUSS
> and
> >> EMIF clockdomains. i.e CM_MPU_STATICDEP.MEMIF_STATDEP = 0
> >>
> >> The issue is under investigation with hardware team.
> >>
> >> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >> Cc: Paul Walmsley <paul@pwsan.com>
> >> Cc: Kevin Hilman <khilman@ti.com>
> >
> > Nice work!
> >
> > Kevin, you want to take this one?
>
> Yup
>
> > My only comment is that it might be nice to add a pr_info("OMAP4
> > PM: Temporary static dependency added between EMIF and MPUSS");
> > in there to reduce the risk that the issue will be forgotten...
> >
> > Acked-by: Paul Walmsley <paul@pwsan.com>
>
> Santosh,
>
> Please update with the pr_info() as suggested by Paul, repost with
> linux-arm-kernel in Cc, add Paul's ack and I'll queue for 2.6.39.
>
Sure.
Regards
Santosh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-09 4:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 15:09 [PATCH] OMAP4: PM: Set static dependency between MPUSS and EMIF Santosh Shilimkar
2011-03-08 23:22 ` Paul Walmsley
2011-03-09 0:12 ` Kevin Hilman
2011-03-09 4:59 ` Santosh Shilimkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox