From: Kevin Hilman <khilman@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: Shweta Gulati <shweta.gulati@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] OMAP4: Enable Turbo and Nitro OPP for OMAP4
Date: Wed, 02 Mar 2011 07:54:21 -0800 [thread overview]
Message-ID: <87ei6pecwi.fsf@ti.com> (raw)
In-Reply-To: <AANLkTiny+AM9p-AsmJwsJttxuuUoDwceZL=7TWRCmphR@mail.gmail.com> (Nishanth Menon's message of "Wed, 2 Mar 2011 16:58:23 +0530")
"Menon, Nishanth" <nm@ti.com> writes:
> On Wed, Feb 16, 2011 at 11:48, Shweta Gulati <shweta.gulati@ti.com> wrote:
>> All OMAP4 boards support OPP-Turbo (800M) and OPP-Nitro (1G).
> s/All OMAP4/Almost all/ - there are a minority of boards that use
> OMAP4430-800 device instead of the OMAP4430-1000 device.
> Also please use the full term 1GHz instead of 1G
>> Enable them by default in OPPTable. For 800Mhz devices where
> s/For 800Mhz/For the small minority of boards which use OMAP4430-800
> (800MHz device),
>> OPP-Nitro is not supported, OPP-Nitro should be disabled
>> from board file.
>
> even though the TI documentation terminology is Turbo, Nitro etc.., I
> suggest using frequencies to better map things historically.
I agree, IMO the Turbo & Nitro names are useless.
Kevin
>>
>> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
>> ---
>> arch/arm/mach-omap2/opp4xxx_data.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c
>> index 705fe9a..48d79e5 100644
>> --- a/arch/arm/mach-omap2/opp4xxx_data.c
>> +++ b/arch/arm/mach-omap2/opp4xxx_data.c
>> @@ -31,9 +31,9 @@ static struct omap_opp_def __initdata omap44xx_opp_def_list[] = {
>> /* MPU OPP2 - OPP100 */
>> OPP_INITIALIZER("mpu", true, 600000000, OMAP4430_VDD_MPU_OPP100_UV),
>> /* MPU OPP3 - OPP-Turbo */
>> - OPP_INITIALIZER("mpu", false, 800000000, OMAP4430_VDD_MPU_OPPTURBO_UV),
>> + OPP_INITIALIZER("mpu", true, 800000000, OMAP4430_VDD_MPU_OPPTURBO_UV),
>> /* MPU OPP4 - OPP-SB */
>> - OPP_INITIALIZER("mpu", false, 1008000000, OMAP4430_VDD_MPU_OPPNITRO_UV),
>> + OPP_INITIALIZER("mpu", true, 1008000000, OMAP4430_VDD_MPU_OPPNITRO_UV),
>> /* L3 OPP1 - OPP50 */
>> OPP_INITIALIZER("l3_main_1", true, 100000000, OMAP4430_VDD_CORE_OPP50_UV),
>> /* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */
>> --
>> 1.7.0.4
>
> I am ok with the overall patch - with the minor suggestions above.
>
> Regards,
> Nishanth Menon
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-02 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 6:18 [PATCH 3/3] OMAP4: Enable Turbo and Nitro OPP for OMAP4 Shweta Gulati
2011-03-02 11:28 ` Menon, Nishanth
2011-03-02 15:54 ` Kevin Hilman [this message]
2011-03-03 9:07 ` Gulati, Shweta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei6pecwi.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=shweta.gulati@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox