linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Manjunatha GK <manjugk@ti.com>
Cc: linux-omap@vger.kernel.org, Benoit Cousson <b-cousson@ti.com>,
	Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
	Anand Sawant <sawant@ti.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Rajendra Nayak <rnayak@ti.com>, Basak Partha <p-basak2@ti.com>,
	Charulatha V <charu@ti.com>
Subject: Re: [PATCH 04/11] OMAP3: DMA: HWMOD: Add hwmod data structures
Date: Tue, 03 Aug 2010 14:56:55 -0700	[thread overview]
Message-ID: <87eiefnyvs.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1280397545-27323-5-git-send-email-manjugk@ti.com> (Manjunatha GK's message of "Thu, 29 Jul 2010 15:28:58 +0530")

Manjunatha GK <manjugk@ti.com> writes:

> This patch adds OMAP3 DMA hwmod structures.
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>

[...]

> +static struct omap_hwmod omap3xxx_dma_system_hwmod = {
> +	.name		= "dma",
> +	.class		= &omap3xxx_dma_hwmod_class,
> +	.mpu_irqs	= omap3xxx_dma_system_irqs,
> +	.mpu_irqs_cnt	= ARRAY_SIZE(omap3xxx_dma_system_irqs),
> +	.main_clk	= "l3_div_ck",
> +	.prcm = {
> +		.omap2 = {
> +			/* .clkctrl_reg = NULL, */
> +		},
> +	},

Has this been tested?  Without valid fields here the hwmod will never be
enabled.

Kevin

  reply	other threads:[~2010-08-03 21:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  9:58 [PATCH 00/11] OMAP: DMA: HWMOD and DMA as platform driver Manjunatha GK
2010-07-29  9:58 ` [PATCH 01/11] OMAP: DMA: Introduce DMA device attributes Manjunatha GK
2010-07-29 12:35   ` Cousson, Benoit
2010-07-30  3:57     ` G, Manjunath Kondaiah
2010-08-04 10:13       ` Cousson, Benoit
2010-08-04 17:21         ` G, Manjunath Kondaiah
2010-08-04 18:13           ` Gadiyar, Anand
2010-07-29  9:58 ` [PATCH 02/11] OMAP2420: DMA: HWMOD: Add hwmod data structures Manjunatha GK
2010-07-29  9:58 ` [PATCH 03/11] OMAP2430: " Manjunatha GK
2010-07-29  9:58 ` [PATCH 04/11] OMAP3: " Manjunatha GK
2010-08-03 21:56   ` Kevin Hilman [this message]
2010-08-04  0:35     ` G, Manjunath Kondaiah
2010-08-04 10:08       ` Cousson, Benoit
2010-08-04 10:15         ` Shilimkar, Santosh
2010-08-04 10:23           ` Cousson, Benoit
2010-08-04 10:27             ` Shilimkar, Santosh
2010-08-04 10:36               ` Cousson, Benoit
2010-08-04 10:38                 ` Shilimkar, Santosh
2010-08-04 17:24                   ` G, Manjunath Kondaiah
2010-07-29  9:58 ` [PATCH 05/11] OMAP4: DMA: HWMOD: update OMAP4 data base Manjunatha GK
2010-07-29 12:48   ` Cousson, Benoit
2010-07-29  9:59 ` [PATCH 06/11] OMAP1: DMA: Introduce DMA driver as platform driver Manjunatha GK
2010-07-29  9:59 ` [PATCH 07/11] OMAP2/3/4: DMA: HWMOD: Device registration Manjunatha GK
2010-07-29  9:59 ` [PATCH 08/11] OMAP: DMA: Convert DMA library into DMA platform Driver Manjunatha GK
2010-07-29  9:59 ` [PATCH 09/11] OMAP: DMA: Implement generic errata handling Manjunatha GK
2010-07-29  9:59 ` [PATCH 10/11] OMAP: DMA: Use DMA device attributes Manjunatha GK
2010-07-29  9:59 ` [PATCH 11/11] sDMA: descriptor autoloading feature Manjunatha GK
2010-07-29 10:30   ` G, Manjunath Kondaiah
2010-08-11  7:43 ` [PATCH 00/11] OMAP: DMA: HWMOD and DMA as platform driver G, Manjunath Kondaiah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eiefnyvs.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=b-cousson@ti.com \
    --cc=charu@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=p-basak2@ti.com \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=sawant@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).