* [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS
@ 2010-01-14 17:05 Aguirre, Sergio
2010-01-14 18:33 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Aguirre, Sergio @ 2010-01-14 17:05 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
>From ec3f04ec8cf4851fceb249acf832755b7aad1766 Mon Sep 17 00:00:00 2001
From: Sergio Aguirre <saaguirre@ti.com>
Date: Thu, 14 Jan 2010 11:01:15 -0600
Subject: [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS
Fix following warning when CONFIG_DEBUG_FS wasn't selected:
arch/arm/mach-omap2/pm-debug.c:57: warning: 'pm_dbg_init' declared 'static' but never defined
Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
---
arch/arm/mach-omap2/pm-debug.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index 860b755..9727484 100644
--- a/arch/arm/mach-omap2/pm-debug.c
+++ b/arch/arm/mach-omap2/pm-debug.c
@@ -54,8 +54,6 @@ int omap2_pm_debug;
regs[reg_count++].val = \
__raw_readl(OMAP2_L4_IO_ADDRESS(0x480fe000 + (off)))
-static int __init pm_dbg_init(void);
-
void omap2_pm_dump(int mode, int resume, unsigned int us)
{
struct reg {
@@ -167,6 +165,8 @@ struct dentry *pm_dbg_dir;
static int pm_dbg_init_done;
+static int __init pm_dbg_init(void);
+
enum {
DEBUG_FILE_COUNTERS = 0,
DEBUG_FILE_TIMERS,
--
1.6.5.3
[-- Attachment #2: 0001-PM-debug-Fix-warning-when-no-CONFIG_DEBUG_FS.patch --]
[-- Type: application/octet-stream, Size: 1131 bytes --]
From ec3f04ec8cf4851fceb249acf832755b7aad1766 Mon Sep 17 00:00:00 2001
From: Sergio Aguirre <saaguirre@ti.com>
Date: Thu, 14 Jan 2010 11:01:15 -0600
Subject: [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS
Fix following warning when CONFIG_DEBUG_FS wasn't selected:
arch/arm/mach-omap2/pm-debug.c:57: warning: 'pm_dbg_init' declared 'static' but never defined
Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
---
arch/arm/mach-omap2/pm-debug.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index 860b755..9727484 100644
--- a/arch/arm/mach-omap2/pm-debug.c
+++ b/arch/arm/mach-omap2/pm-debug.c
@@ -54,8 +54,6 @@ int omap2_pm_debug;
regs[reg_count++].val = \
__raw_readl(OMAP2_L4_IO_ADDRESS(0x480fe000 + (off)))
-static int __init pm_dbg_init(void);
-
void omap2_pm_dump(int mode, int resume, unsigned int us)
{
struct reg {
@@ -167,6 +165,8 @@ struct dentry *pm_dbg_dir;
static int pm_dbg_init_done;
+static int __init pm_dbg_init(void);
+
enum {
DEBUG_FILE_COUNTERS = 0,
DEBUG_FILE_TIMERS,
--
1.6.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS
2010-01-14 17:05 [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS Aguirre, Sergio
@ 2010-01-14 18:33 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2010-01-14 18:33 UTC (permalink / raw)
To: Aguirre, Sergio; +Cc: linux-omap@vger.kernel.org
"Aguirre, Sergio" <saaguirre@ti.com> writes:
> From ec3f04ec8cf4851fceb249acf832755b7aad1766 Mon Sep 17 00:00:00 2001
> From: Sergio Aguirre <saaguirre@ti.com>
> Date: Thu, 14 Jan 2010 11:01:15 -0600
> Subject: [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS
>
> Fix following warning when CONFIG_DEBUG_FS wasn't selected:
>
> arch/arm/mach-omap2/pm-debug.c:57: warning: 'pm_dbg_init' declared 'static' but never defined
>
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
Thanks, adding to PM branch and queuing in pm-fixes for 2.6.33-rc.
Kevin
> ---
> arch/arm/mach-omap2/pm-debug.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
> index 860b755..9727484 100644
> --- a/arch/arm/mach-omap2/pm-debug.c
> +++ b/arch/arm/mach-omap2/pm-debug.c
> @@ -54,8 +54,6 @@ int omap2_pm_debug;
> regs[reg_count++].val = \
> __raw_readl(OMAP2_L4_IO_ADDRESS(0x480fe000 + (off)))
>
> -static int __init pm_dbg_init(void);
> -
> void omap2_pm_dump(int mode, int resume, unsigned int us)
> {
> struct reg {
> @@ -167,6 +165,8 @@ struct dentry *pm_dbg_dir;
>
> static int pm_dbg_init_done;
>
> +static int __init pm_dbg_init(void);
> +
> enum {
> DEBUG_FILE_COUNTERS = 0,
> DEBUG_FILE_TIMERS,
> --
> 1.6.5.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-14 18:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 17:05 [PATCH] PM debug: Fix warning when no CONFIG_DEBUG_FS Aguirre, Sergio
2010-01-14 18:33 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox