From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] ARM: OMAP2+: PRM: fix compile for OMAP4-only build Date: Thu, 05 Apr 2012 17:07:31 -0700 Message-ID: <87fwchhge4.fsf@ti.com> References: <1333660837-23249-1-git-send-email-khilman@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:39488 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255Ab2DFAHd (ORCPT ); Thu, 5 Apr 2012 20:07:33 -0400 Received: by dady13 with SMTP id y13so2214652dad.13 for ; Thu, 05 Apr 2012 17:07:31 -0700 (PDT) In-Reply-To: (Paul Walmsley's message of "Thu, 5 Apr 2012 15:33:32 -0600 (MDT)") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Paul Walmsley writes: > On Thu, 5 Apr 2012, Kevin Hilman wrote: > >> For OMAP4 only builds, the omap2_prm_* functions have dummy wrappers >> to detect incorrect usage. However, several unrelated omap3 PRM >> functions have made it inside the #else clause of the #ifdef wrapping >> the omap2_prm stubs, causing them to disappear on OMAP4-only builds. >> >> This was unnoticed until the IO chain support was added and introduced >> a new function in this section which is referenced by omap_hwmod.c: >> >> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c: In function '_reconfigure_io_chain': >> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c:1665:3: error: implicit declaration of function 'omap3xxx_prm_reconfigure_io_chain' [-Werror=implicit-fungiction-declaration] >> >> Fix by using the #ifdef to only wrap the omap2_prm functions that >> need stubs on OMAP4-only builds. >> >> Cc: Paul Walmsley >> Signed-off-by: Kevin Hilman >> --- >> Paul, this patch applies on top your io_chain_devel_3.5 branch. > > Thanks, Tony reported this too. Any objections to me rolling this into > the offending patch? No objections. Kevin