From: Kevin Hilman <khilman@ti.com>
To: hvaibhav@ti.com
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, tony@atomide.com,
linux-arm-kernel@lists.infradead.org,
Afzal Mohammed <afzal@ti.com>
Subject: Re: [PATCH-V3 2/4] arm:omap:am33xx: Update common OMAP machine specific sources
Date: Mon, 26 Sep 2011 11:45:58 -0700 [thread overview]
Message-ID: <87fwjjcfbt.fsf@ti.com> (raw)
In-Reply-To: <1316529142-27564-3-git-send-email-hvaibhav@ti.com> (hvaibhav@ti.com's message of "Tue, 20 Sep 2011 20:02:20 +0530")
<hvaibhav@ti.com> writes:
> From: Afzal Mohammed <afzal@ti.com>
>
> This patch updates the common machine specific source files for
> support for AM33XX/AM335x with cpu type, macros for identification of
> AM33XX/AM335X device.
>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
[...]
> @@ -3576,7 +3579,8 @@ int __init omap3xxx_clk_init(void)
> * Lock DPLL5 -- here only until other device init code can
> * handle this
> */
> - if (!cpu_is_ti816x() && (omap_rev() >= OMAP3430_REV_ES2_0))
> + if (!cpu_is_ti816x() && !cpu_is_am33xx() &&
> + (omap_rev() >= OMAP3430_REV_ES2_0))
> omap3_clk_lock_dpll5();
This is getting ugly.
Instead of continuing to expand this if-list, I think it's time for a
new feature-flag for whether or not an SoC has DPLL5 instead.
Kevin
next prev parent reply other threads:[~2011-09-26 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 14:32 [PATCH-V3 2/4] arm:omap:am33xx: Update common OMAP machine specific sources hvaibhav
2011-09-26 18:45 ` Kevin Hilman [this message]
2011-09-30 12:09 ` Premi, Sanjeev
2011-09-30 17:09 ` Kevin Hilman
2011-10-06 23:03 ` Tony Lindgren
2011-11-03 13:48 ` Hiremath, Vaibhav
2011-11-05 9:41 ` Hiremath, Vaibhav
2011-11-05 10:29 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwjjcfbt.fsf@ti.com \
--to=khilman@ti.com \
--cc=afzal@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox