[PATCH] arm: plat-omap: counter_32k: Fix build error due to IS_ERR

[PATCH] arm: plat-omap: counter_32k: Fix build error due to IS_ERR

[Sourav Poddar]

Fix the following build error by including linux/err.h
arch/arm/plat-omap/counter_32k.c: In function 'omap_init_clocksource_32k':
arch/arm/plat-omap/counter_32k.c:167: error: implicit declaration of
                                      function 'IS_ERR'

The above error is due to the following commit:
subject: arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
commit: 235fbace0334c846c21e902f330020122fc85955

Created on linux-omap-2.6 branch: omap-fixes

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
Reviewed-by: Charulatha V <charu@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/plat-omap/counter_32k.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
index c1e0d00..8722a13 100644
--- a/arch/arm/plat-omap/counter_32k.c
+++ b/arch/arm/plat-omap/counter_32k.c
@@ -16,6 +16,7 @@
 #include <linux/init.h>
 #include <linux/clk.h>
 #include <linux/io.h>
+#include <linux/err.h>
 
 #include <plat/common.h>
 #include <plat/board.h>
-- 
1.7.0.4

Re: [PATCH] arm: plat-omap: counter_32k: Fix build error due to IS_ERR

[Felipe Balbi]

On Tue, Dec 07, 2010 at 05:39:37PM +0530, Sourav Poddar wrote:
>Fix the following build error by including linux/err.h
>arch/arm/plat-omap/counter_32k.c: In function 'omap_init_clocksource_32k':
>arch/arm/plat-omap/counter_32k.c:167: error: implicit declaration of
>                                      function 'IS_ERR'
>
>The above error is due to the following commit:
>subject: arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
>commit: 235fbace0334c846c21e902f330020122fc85955
>
>Created on linux-omap-2.6 branch: omap-fixes
>
>Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
>Reviewed-by: Charulatha V <charu@ti.com>
>Acked-by: Felipe Balbi <balbi@ti.com>

BTW, since this isn't in mainline yet, Tony you might want to fold into
the orignal patch and just a note that Sourav has updated the commit to
fix a compile error together with SOB ??

-- 
balbi

Re: [PATCH] arm: plat-omap: counter_32k: Fix build error due to IS_ERR

[Kevin Hilman]

Sourav Poddar <sourav.poddar@ti.com> writes:

> Fix the following build error by including linux/err.h
> arch/arm/plat-omap/counter_32k.c: In function 'omap_init_clocksource_32k':
> arch/arm/plat-omap/counter_32k.c:167: error: implicit declaration of
>                                       function 'IS_ERR'
>
> The above error is due to the following commit:
> subject: arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
> commit: 235fbace0334c846c21e902f330020122fc85955
>
> Created on linux-omap-2.6 branch: omap-fixes
>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> Reviewed-by: Charulatha V <charu@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

Just noticed this one too.

Kevin