Re: [PATCH 2/2] OMAP2+: GPIO: move late PM out of interrupts-disabled idle path

[Kevin Hilman <khilman@deeprootsystems.com>]

"Varadarajan, Charulatha" <charu@ti.com> writes:

[...]

>> -void omap2_gpio_prepare_for_idle(int power_state)
>> +void omap2_gpio_prepare_for_idle(void)
>>  {
>> -	int i, c = 0;
>> -	int min = 0;
>> +	int i, c = 0, min = 0;
>> +	int per_next_state;
>> +
>> +	if (!per_pwrdm)
>> +		return;
>
> "per_pwrdm" is not available for OMAP24xx. Hence
> this breaks the omap2_gpio_prepare_for_idle() path for OMAP2.
>
> In OMAP2420, all gpio banks are in wakeup domain and
> in OMAP2430 GPIO banks 1-4 are in wakeup domain & GPIO5 is
> in core domain.

Sure, this patch is just a proof of concept that we can move the GPIO
idle management out of the interrupts disabled path.

When you adapt this approach to your conversion series, since you have
already broken these functions up to be per-bank, you can have a
per-bank powerdomain that can be configured per-SoC.

Kevin