public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Sergio Aguirre <saaguirre@ti.com>
Cc: linux-omap@vger.kernel.org,
	Vikram Pandita <vikram.pandita@ti.com>,
	Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [RFC part1/2 merge v2 RESEND][PATCH 05/10] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs
Date: Mon, 08 Mar 2010 09:55:57 -0800	[thread overview]
Message-ID: <87fx4au28i.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1268069332-14082-6-git-send-email-saaguirre@ti.com> (Sergio Aguirre's message of "Mon\,  8 Mar 2010 11\:28\:47 -0600")

Sergio Aguirre <saaguirre@ti.com> writes:

> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>

This one needs a descriptive changelog.

Kevin

> ---
>  arch/arm/mach-omap2/pm34xx.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index fee2efb..81082f2 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -734,6 +734,9 @@ static void __init omap3_d2d_idle(void)
>  
>  static void __init prcm_setup_regs(void)
>  {
> +	u32 omap3630_auto_uart4 = cpu_is_omap3630() ? OMAP3630_AUTO_UART4 : 0;
> +	u32 omap3630_en_uart4 = cpu_is_omap3630() ? OMAP3630_EN_UART4 : 0;
> +
>  	/* XXX Reset all wkdeps. This should be done when initializing
>  	 * powerdomains */
>  	prm_write_mod_reg(0, OMAP3430_IVA2_MOD, PM_WKDEP);
> @@ -820,6 +823,7 @@ static void __init prcm_setup_regs(void)
>  		CM_AUTOIDLE);
>  
>  	cm_write_mod_reg(
> +		omap3630_auto_uart4 |
>  		OMAP3430_AUTO_GPIO6 |
>  		OMAP3430_AUTO_GPIO5 |
>  		OMAP3430_AUTO_GPIO4 |
> @@ -899,14 +903,14 @@ static void __init prcm_setup_regs(void)
>  			  OMAP3430_EN_GPIO4 | OMAP3430_EN_GPIO5 |
>  			  OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3 |
>  			  OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> -			  OMAP3430_EN_MCBSP4,
> +			  OMAP3430_EN_MCBSP4 | omap3630_en_uart4,
>  			  OMAP3430_PER_MOD, PM_WKEN);
>  	/* and allow them to wake up MPU */
>  	prm_write_mod_reg(OMAP3430_GRPSEL_GPIO2 | OMAP3430_EN_GPIO3 |
>  			  OMAP3430_GRPSEL_GPIO4 | OMAP3430_EN_GPIO5 |
>  			  OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3 |
>  			  OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> -			  OMAP3430_EN_MCBSP4,
> +			  OMAP3430_EN_MCBSP4 | omap3630_en_uart4,
>  			  OMAP3430_PER_MOD, OMAP3430_PM_MPUGRPSEL);
>  
>  	/* Don't attach IVA interrupts */
> -- 
> 1.6.3.3

  reply	other threads:[~2010-03-08 17:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08 17:28 [RFC part1/2 merge v2 RESEND][PATCH 00/10] omap2/3/4: uart4 fixes + zoom2/3 changes Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr Sergio Aguirre
2010-03-08 18:24   ` Felipe Balbi
2010-03-08 20:28     ` Aguirre, Sergio
2010-03-08 21:40       ` Kevin Hilman
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 02/10] omap2/3/4: serial: Remove condition for getting uart4_phys Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 03/10] ARM: OMAP3630: PRCM: Add UART4 control bits Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 04/10] OMAP clock: Add uart4_ick/fck definitions for 3630 Sergio Aguirre
2010-03-08 18:28   ` Felipe Balbi
2010-03-08 20:30     ` Aguirre, Sergio
2010-03-08 21:40       ` Kevin Hilman
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 05/10] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs Sergio Aguirre
2010-03-08 17:55   ` Kevin Hilman [this message]
2010-03-08 18:01     ` Aguirre, Sergio
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630 Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 07/10] omap3: zoom2/3 / 3630sdp: Don't init always all uarts Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 08/10] omap3: 3630sdp: Explicitly enable all UARTs Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 09/10] omap3: zoom 2/3: Change debugboard serial port id Sergio Aguirre
2010-03-08 17:59   ` Kevin Hilman
2010-03-08 18:02     ` Aguirre, Sergio
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 10/10] omap3: zoom2/3: Register only 1 8250 port Sergio Aguirre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fx4au28i.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=saaguirre@ti.com \
    --cc=tony@atomide.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox