From: Kevin Hilman <khilman@deeprootsystems.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: PM: warn if CONFIG_CPU_IDLE is not enabled
Date: Wed, 05 Aug 2009 08:33:37 -0700 [thread overview]
Message-ID: <87fxc68ecu.fsf@deeprootsystems.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0908030138020.19529@utopia.booyaka.com> (Paul Walmsley's message of "Mon\, 3 Aug 2009 01\:39\:02 -0600 \(MDT\)")
Paul Walmsley <paul@pwsan.com> writes:
> For MPU latency constraints to work, CONFIG_CPU_IDLE must be enabled,
> since CPUIdle is where the constraints are evaluated. Warn during
> compilation if CONFIG_CPU_IDLE is not defined.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
Thanks, pushing to PM branch.
Kevin
> ---
> arch/arm/mach-omap2/resource34xx.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
> index 25535a3..1693e9b 100644
> --- a/arch/arm/mach-omap2/resource34xx.c
> +++ b/arch/arm/mach-omap2/resource34xx.c
> @@ -28,6 +28,10 @@
> #include "cm.h"
> #include "cm-regbits-34xx.h"
>
> +#ifndef CONFIG_CPU_IDLE
> +#warning MPU latency constraints require CONFIG_CPU_IDLE to function!
> +#endif
> +
> /**
> * init_latency - Initializes the mpu/core latency resource.
> * @resp: Latency resource to be initalized
> --
> 1.6.3.GIT
prev parent reply other threads:[~2009-08-05 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 7:39 [PATCH] OMAP: PM: warn if CONFIG_CPU_IDLE is not enabled Paul Walmsley
2009-08-05 15:33 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxc68ecu.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox