public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP: PM: warn if CONFIG_CPU_IDLE is not enabled
@ 2009-08-03  7:39 Paul Walmsley
  2009-08-05 15:33 ` Kevin Hilman
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Walmsley @ 2009-08-03  7:39 UTC (permalink / raw)
  To: linux-omap; +Cc: khilman


For MPU latency constraints to work, CONFIG_CPU_IDLE must be enabled,
since CPUIdle is where the constraints are evaluated.  Warn during
compilation if CONFIG_CPU_IDLE is not defined.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
 arch/arm/mach-omap2/resource34xx.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
index 25535a3..1693e9b 100644
--- a/arch/arm/mach-omap2/resource34xx.c
+++ b/arch/arm/mach-omap2/resource34xx.c
@@ -28,6 +28,10 @@
 #include "cm.h"
 #include "cm-regbits-34xx.h"
 
+#ifndef CONFIG_CPU_IDLE
+#warning MPU latency constraints require CONFIG_CPU_IDLE to function!
+#endif
+
 /**
  * init_latency - Initializes the mpu/core latency resource.
  * @resp: Latency resource to be initalized
-- 
1.6.3.GIT


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] OMAP: PM: warn if CONFIG_CPU_IDLE is not enabled
  2009-08-03  7:39 [PATCH] OMAP: PM: warn if CONFIG_CPU_IDLE is not enabled Paul Walmsley
@ 2009-08-05 15:33 ` Kevin Hilman
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2009-08-05 15:33 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: linux-omap

Paul Walmsley <paul@pwsan.com> writes:

> For MPU latency constraints to work, CONFIG_CPU_IDLE must be enabled,
> since CPUIdle is where the constraints are evaluated.  Warn during
> compilation if CONFIG_CPU_IDLE is not defined.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>

Thanks, pushing to PM branch.

Kevin

> ---
>  arch/arm/mach-omap2/resource34xx.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
> index 25535a3..1693e9b 100644
> --- a/arch/arm/mach-omap2/resource34xx.c
> +++ b/arch/arm/mach-omap2/resource34xx.c
> @@ -28,6 +28,10 @@
>  #include "cm.h"
>  #include "cm-regbits-34xx.h"
>  
> +#ifndef CONFIG_CPU_IDLE
> +#warning MPU latency constraints require CONFIG_CPU_IDLE to function!
> +#endif
> +
>  /**
>   * init_latency - Initializes the mpu/core latency resource.
>   * @resp: Latency resource to be initalized
> -- 
> 1.6.3.GIT

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-05 15:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-03  7:39 [PATCH] OMAP: PM: warn if CONFIG_CPU_IDLE is not enabled Paul Walmsley
2009-08-05 15:33 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox