From: Kevin Hilman <khilman@deeprootsystems.com>
To: Hemanth V <hemanthv@ti.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH 1/2] McSPI Slave and DMA,FIFO support
Date: Thu, 11 Jun 2009 09:29:49 -0700 [thread overview]
Message-ID: <87fxe6rawy.fsf@deeprootsystems.com> (raw)
In-Reply-To: <000e01c9eaab$93825830$LocalHost@wipultra793> (Hemanth V.'s message of "Thu\, 11 Jun 2009 21\:14\:55 +0530")
"Hemanth V" <hemanthv@ti.com> writes:
>>
>> A Santosh suggested, you need to break this up into parts that are
>> OMAP specific (arch/arm/*) and parts that go via the SPI subsystem
>> (drivers/spi/*.) If doing this breaks your series, then fix it
>
> But then that would cause a problem, we will not be able to
> use arch/arm/plat-omap/include/mach/mcspi.h and will need to redefine those
> variables in omap2_mcspi.c which obviously is not the preferred way.
Anything shared between the driver and the arch code should go
into <mach/mcspi.h>, this way the arch code always compiles.
For the driver code, when it's submitted upstream, you state that it
has a dependency on the arch code if it is not yet upstream.
The point is to separate out the arch code and get it submitted/merged
asap so driver code has a smooth path.
Kevin
prev parent reply other threads:[~2009-06-11 16:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 5:56 [PATCH 1/2] McSPI Slave and DMA,FIFO support Hemanth V
2009-05-20 6:04 ` Shilimkar, Santosh
2009-05-20 6:06 ` Hemanth V
2009-05-26 13:48 ` Hemanth V
2009-06-02 18:06 ` Tony Lindgren
2009-06-05 9:58 ` Hemanth V
2009-06-11 14:29 ` Hemanth V
2009-06-11 14:47 ` Kevin Hilman
2009-06-11 15:44 ` Hemanth V
2009-06-11 16:29 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxe6rawy.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=david-b@pacbell.net \
--cc=hemanthv@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox