* [PATCH] OMAP3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE
@ 2008-12-11 14:46 Tero Kristo
2008-12-15 22:22 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Tero Kristo @ 2008-12-11 14:46 UTC (permalink / raw)
To: linux-omap
MPU and CORE should stay awake if there is CAM domain ACTIVE. This is
because that module doesn't have wake-up capability.
This should replace the patch that is currently in the PM branch.
Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
---
arch/arm/mach-omap2/pm34xx.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index bc2d4bc..2eafb55 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -83,6 +83,7 @@ static void (*saved_idle)(void);
static struct powerdomain *mpu_pwrdm, *neon_pwrdm;
static struct powerdomain *core_pwrdm, *per_pwrdm;
+static struct powerdomain *cam_pwrdm;
static inline void omap3_per_save_context(void)
{
@@ -335,6 +336,9 @@ void omap_sram_idle(void)
}
}
+ if (pwrdm_read_pwrst(cam_pwrdm) == PWRDM_POWER_ON)
+ omap2_clkdm_deny_idle(mpu_pwrdm->pwrdm_clkdms[0]);
+
/* CORE */
if (core_next_state < PWRDM_POWER_ON) {
omap_uart_prepare_idle(0);
@@ -402,6 +406,8 @@ void omap_sram_idle(void)
omap_uart_resume_idle(1);
}
+ omap2_clkdm_allow_idle(mpu_pwrdm->pwrdm_clkdms[0]);
+
/* PER */
if (per_next_state < PWRDM_POWER_ON) {
per_prev_state = pwrdm_read_prev_pwrst(per_pwrdm);
@@ -953,6 +959,7 @@ int __init omap3_pm_init(void)
neon_pwrdm = pwrdm_lookup("neon_pwrdm");
per_pwrdm = pwrdm_lookup("per_pwrdm");
core_pwrdm = pwrdm_lookup("core_pwrdm");
+ cam_pwrdm = pwrdm_lookup("cam_pwrdm");
omap_push_sram_idle();
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OMAP3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE
2008-12-11 14:46 [PATCH] OMAP3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE Tero Kristo
@ 2008-12-15 22:22 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2008-12-15 22:22 UTC (permalink / raw)
To: Tero Kristo; +Cc: linux-omap
Tero Kristo <tero.kristo@nokia.com> writes:
> MPU and CORE should stay awake if there is CAM domain ACTIVE. This is
> because that module doesn't have wake-up capability.
>
> This should replace the patch that is currently in the PM branch.
>
> Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
Thanks, applied to PM branch after reverting previous buggy version.
Kevin
> ---
> arch/arm/mach-omap2/pm34xx.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index bc2d4bc..2eafb55 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -83,6 +83,7 @@ static void (*saved_idle)(void);
>
> static struct powerdomain *mpu_pwrdm, *neon_pwrdm;
> static struct powerdomain *core_pwrdm, *per_pwrdm;
> +static struct powerdomain *cam_pwrdm;
>
> static inline void omap3_per_save_context(void)
> {
> @@ -335,6 +336,9 @@ void omap_sram_idle(void)
> }
> }
>
> + if (pwrdm_read_pwrst(cam_pwrdm) == PWRDM_POWER_ON)
> + omap2_clkdm_deny_idle(mpu_pwrdm->pwrdm_clkdms[0]);
> +
> /* CORE */
> if (core_next_state < PWRDM_POWER_ON) {
> omap_uart_prepare_idle(0);
> @@ -402,6 +406,8 @@ void omap_sram_idle(void)
> omap_uart_resume_idle(1);
> }
>
> + omap2_clkdm_allow_idle(mpu_pwrdm->pwrdm_clkdms[0]);
> +
> /* PER */
> if (per_next_state < PWRDM_POWER_ON) {
> per_prev_state = pwrdm_read_prev_pwrst(per_pwrdm);
> @@ -953,6 +959,7 @@ int __init omap3_pm_init(void)
> neon_pwrdm = pwrdm_lookup("neon_pwrdm");
> per_pwrdm = pwrdm_lookup("per_pwrdm");
> core_pwrdm = pwrdm_lookup("core_pwrdm");
> + cam_pwrdm = pwrdm_lookup("cam_pwrdm");
>
> omap_push_sram_idle();
>
> --
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-15 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-11 14:46 [PATCH] OMAP3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE Tero Kristo
2008-12-15 22:22 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox