From mboxrd@z Thu Jan 1 00:00:00 1970 From: jouni.hogander@nokia.com (=?utf-8?Q?H=C3=B6gander?= Jouni) Subject: Re: [PATCH 03/10] OMAP3 SRF: omap3 srf driver Date: Wed, 13 Aug 2008 10:08:42 +0300 Message-ID: <87fxp95r45.fsf@trdhcp146196.ntc.nokia.com> References: <46647.192.168.10.89.1218459995.squirrel@dbdmail.itg.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.nokia.com ([192.100.122.230]:19193 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbYHMHJK convert rfc822-to-8bit (ORCPT ); Wed, 13 Aug 2008 03:09:10 -0400 In-Reply-To: <46647.192.168.10.89.1218459995.squirrel@dbdmail.itg.ti.com> (ext Rajendra Nayak's message of "Mon, 11 Aug 2008 18:36:35 +0530 (IST)") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Rajendra Nayak Cc: linux-omap@vger.kernel.org "ext Rajendra Nayak" writes: > +int set_pd_latency(struct shared_resource *resp, u32 latency) > +{ > + u32 pd_lat_level, ind, i; > + struct pd_latency_db *pd_lat_db; > + struct powerdomain *pwrdm; > + > + pd_lat_db =3D resp->resource_data; > + pwrdm =3D pd_lat_db->pd; > + pd_lat_level =3D PD_LATENCY_OFF; > + /* using the latency db map to the appropriate PD state */ > + for (ind =3D 0; ind < PD_LATENCY_MAXLEVEL; ind++) > + if (pd_lat_db->latency[ind] < latency) > + pd_lat_level =3D ind; > + > + resp->curr_level =3D pd_lat_level; > + switch (pd_lat_level) { > + case PWRDM_POWER_OFF: > + case PWRDM_POWER_RET: > + /* Errata 1.29: No transitions from INACTIVE to RET/OFF > + * possible. > + * Need to be taken care of here. > + */ > + if (pwrdm_read_pwrst(pwrdm) !=3D PWRDM_POWER_ON) { > + /* Force the clock domains to ON */ > + for (i =3D 0; pwrdm->pwrdm_clkdms[i]; i++) { > + omap2_clkdm_deny_idle(pwrdm->pwrdm_clkdms[i]); > + omap2_clkdm_wakeup(pwrdm->pwrdm_clkdms[i]); > + } > + pwrdm_set_next_pwrst(pwrdm, PWRDM_POWER_ON); > + pwrdm_set_next_pwrst(pwrdm, pd_lat_level); > + for (i =3D 0; pwrdm->pwrdm_clkdms[i]; i++) { > + omap2_clkdm_sleep(pwrdm->pwrdm_clkdms[i]); > + omap2_clkdm_allow_idle(pwrdm->pwrdm_clkdms[i]); > + } > + } else > + pwrdm_set_next_pwrst(pwrdm, pd_lat_level); You could use set_pwrdm_state from pm34xx.c here and update it if necessary. This way your workaround for errate 1.29 would be available for cpuidle, pm_idle, srf and suspend. --=20 Jouni H=C3=B6gander -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html