From: Kevin Hilman <khilman@deeprootsystems.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
linux@arm.linux.org.uk, paul@pwsan.com,
yongjun_wei@trendmicro.com.cn, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] gpio/omap: fix possible memory leak in omap2_gpio_dev_init()
Date: Fri, 07 Sep 2012 15:37:39 -0700 [thread overview]
Message-ID: <87har9ihn0.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20120907222416.GR1303@atomide.com> (Tony Lindgren's message of "Fri, 7 Sep 2012 15:24:17 -0700")
Tony Lindgren <tony@atomide.com> writes:
> * Kevin Hilman <khilman@deeprootsystems.com> [120907 15:07]:
>> Wei Yongjun <weiyj.lk@gmail.com> writes:
>>
>> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>> >
>> > pdata and pdata->regs have been allocated in this function and
>> > should be freed before leaving it, and in the other error handling
>> > cases too.
>> >
>> > spatch with a semantic match is used to found this problem.
>> > (http://coccinelle.lip6.fr/)
>> >
>> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Acked-by: Kevin Hilman <khilman@ti.com>
>>
>> Tony, can you pick this one up for fixes?
>
> Sure, is fixes-noncritical OK for this one?
Yes.
Kevin
prev parent reply other threads:[~2012-09-07 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 12:42 [PATCH v2] gpio/omap: fix possible memory leak in omap2_gpio_dev_init() Wei Yongjun
2012-09-07 22:06 ` Kevin Hilman
2012-09-07 22:24 ` Tony Lindgren
2012-09-07 22:37 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87har9ihn0.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox