From: Kevin Hilman <khilman@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, b-cousson@ti.com
Subject: Re: [PATCHv10 06/14] omap3: pm: use prcm chain handler
Date: Fri, 09 Dec 2011 15:23:13 -0800 [thread overview]
Message-ID: <87hb19jpni.fsf@ti.com> (raw)
In-Reply-To: <1323440857-385-7-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Fri, 9 Dec 2011 16:27:29 +0200")
Tero Kristo <t-kristo@ti.com> writes:
> PM interrupt handling is now done through the PRCM chain handler. The
> interrupt handling logic is also split in two parts, to serve IO and
> WKUP events separately. This allows us to handle IO chain events in a
> clean way.
Also, elaborate that this means this core event code should no longer
clear the IO events since they are now handled by their own handlers.
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
[...]
> @@ -880,12 +848,20 @@ static int __init omap3_pm_init(void)
> * supervised mode for powerdomains */
> prcm_setup_regs();
>
> - ret = request_irq(INT_34XX_PRCM_MPU_IRQ,
> - (irq_handler_t)prcm_interrupt_handler,
> - IRQF_DISABLED, "prcm", NULL);
> + ret = request_irq(omap_prcm_event_to_irq("wkup"),
> + _prcm_int_handle_wakeup, 0, "pm_wkup", NULL);
> +
> + if (ret) {
> + printk(KERN_ERR "Failed to request pm_wkup irq\n");
> + goto err1;
> + }
> +
> + /* IO interrupt is shared with mux code */
> + ret = request_irq(omap_prcm_event_to_irq("io"),
> + _prcm_int_handle_io, IRQF_SHARED, "pm_io", omap3_pm_init);
> +
Why does the "hwmod_io" use IRQF_NO_SUSPEND and this one doesn't?
Kevin
next prev parent reply other threads:[~2011-12-09 23:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 14:27 [PATCHv10 00/14] PRCM chain handler Tero Kristo
2011-12-09 14:27 ` [PATCHv10 01/14] OMAP2+: hwmod: Add API to enable IO ring wakeup Tero Kristo
2011-12-09 14:27 ` [PATCHv10 02/14] OMAP2+: hwmod: Add API to check IO PAD wakeup status Tero Kristo
2011-12-09 14:27 ` [PATCHv10 03/14] omap: prm: add support for chain interrupt handler Tero Kristo
2011-12-09 14:27 ` [PATCHv10 04/14] omap: prm: add support for suspend prepare and finish callbacks Tero Kristo
2011-12-09 23:04 ` Kevin Hilman
2011-12-12 9:57 ` Tero Kristo
2011-12-09 14:27 ` [PATCHv10 05/14] OMAP2+: mux: add support for PAD wakeup interrupts Tero Kristo
2011-12-09 23:13 ` Kevin Hilman
2011-12-12 10:01 ` Tero Kristo
2011-12-12 15:07 ` Kevin Hilman
2011-12-09 14:27 ` [PATCHv10 06/14] omap3: pm: use prcm chain handler Tero Kristo
2011-12-09 23:23 ` Kevin Hilman [this message]
2011-12-12 9:55 ` Tero Kristo
2011-12-09 14:27 ` [PATCHv10 07/14] OMAP3: pm: do not enable PRCM MPU interrupts manually Tero Kristo
2011-12-09 14:27 ` [PATCHv10 08/14] TEMP: serial: added mux support Tero Kristo
2011-12-09 14:27 ` [PATCHv10 09/14] TEMP: 4430sdp: use common serial init with " Tero Kristo
2011-12-09 14:27 ` [PATCHv10 10/14] TEMP: mux: added trace for io wkup event Tero Kristo
2011-12-09 14:27 ` [PATCHv10 11/14] TEMP: OMAP3: pm: remove serial resume / idle calls from idle path Tero Kristo
2011-12-09 14:27 ` [PATCHv10 12/14] TEMP: OMAP3: serial: made serial to work properly with PRCM chain handler Tero Kristo
2011-12-09 14:27 ` [PATCHv10 13/14] TEMP: OMAP: serial: remove padconf hacks Tero Kristo
2011-12-09 14:27 ` [PATCHv10 14/14] TEMP: OMAP device: change pr_warnings to pr_debugs Tero Kristo
2011-12-09 22:36 ` [PATCHv10 00/14] PRCM chain handler Kevin Hilman
2011-12-12 9:56 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb19jpni.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).