From: Kevin Hilman <khilman@ti.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Ben Dooks <ben-linux@fluff.org>, Tony Lindgren <tony@atomide.com>,
Andy Green <andy.green@linaro.org>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Linux I2C <linux-i2c@vger.kernel.org>,
linux-omap@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: 10-bit address support in i2c-omap and i2c-davinci
Date: Mon, 07 Nov 2011 07:09:38 -0800 [thread overview]
Message-ID: <87hb2g0y19.fsf@ti.com> (raw)
In-Reply-To: <20111107094614.0062a3f7@endymion.delvare> (Jean Delvare's message of "Mon, 7 Nov 2011 09:46:14 +0100")
Adding linux-omap and linux-davinci lists
Jean Delvare <khali@linux-fr.org> writes:
> Both bus drivers i2c-omap and i2c-davinci apparently handle 10-bit addresses:
>
> (i2c-omap.c)
> if (msg->flags & I2C_M_TEN)
> w |= OMAP_I2C_CON_XA;
>
> (i2c-davinci.c)
> /* if the slave address is ten bit address, enable XA bit */
> if (msg->flags & I2C_M_TEN)
> flag |= DAVINCI_I2C_MDR_XA;
>
> However neither driver declares functionality flag I2C_FUNC_10BIT_ADDR,
> so chip drivers would normally refuse to bind to these buses. If 10-bit
> address support is incomplete or broken then it should be removed
> completely. If it works then these drivers should declare so by adding
> I2C_FUNC_10BIT_ADDR to the functionality flags they return.
next parent reply other threads:[~2011-11-07 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111107094614.0062a3f7@endymion.delvare>
2011-11-07 15:09 ` Kevin Hilman [this message]
2011-11-07 16:59 ` 10-bit address support in i2c-omap and i2c-davinci Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb2g0y19.fsf@ti.com \
--to=khilman@ti.com \
--cc=andy.green@linaro.org \
--cc=ben-linux@fluff.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox