From: Kevin Hilman <khilman@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Felipe Balbi <balbi@ti.com>,
"Koyamangalath, Abhilash" <abhilash.kv@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: watchdog pdev id set to -1
Date: Mon, 28 Feb 2011 16:35:06 -0800 [thread overview]
Message-ID: <87hbbnlltx.fsf@ti.com> (raw)
In-Reply-To: <20110222215923.GB28740@sirena.org.uk> (Mark Brown's message of "Tue, 22 Feb 2011 21:59:23 +0000")
Mark Brown <broonie@opensource.wolfsonmicro.com> writes:
> On Fri, Feb 18, 2011 at 01:12:37PM +0200, Felipe Balbi wrote:
>
>> On Fri, Feb 18, 2011 at 04:39:48PM +0530, Koyamangalath, Abhilash wrote:
>> > I understand, but is there a subtle reason why are starting from
>> > an erroneous-looking -1 rather than a more natural 0 (or 1 ?).
>
>> -1 means no ID. The IDs are zero-based, so we can't use zero. Just
>> change that value and see how things change on sysfs and dmesg then you
>> will know what I'm talking about. That's just an implementation decision
>> of using -1 to signify "no ID needed".
>
> Though looking at the report it looks like the omap_device print that's
> done during boot is doing the wrong thing here and displaying the -1
> instead of masking it from the print which is what's expected.
Agreed.
Abhilash, Just send a patch to fix the omap_device printk which is the
confusing part.
Kevin
prev parent reply other threads:[~2011-03-01 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 10:41 watchdog pdev id set to -1 Koyamangalath, Abhilash
2011-02-18 10:56 ` Felipe Balbi
2011-02-18 11:09 ` Koyamangalath, Abhilash
2011-02-18 11:12 ` Felipe Balbi
2011-02-22 21:59 ` Mark Brown
2011-03-01 0:35 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbbnlltx.fsf@ti.com \
--to=khilman@ti.com \
--cc=abhilash.kv@ti.com \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox