From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: watchdog pdev id set to -1 Date: Mon, 28 Feb 2011 16:35:06 -0800 Message-ID: <87hbbnlltx.fsf@ti.com> References: <20110218105635.GB10489@legolas.emea.dhcp.ti.com> <20110218111237.GE10489@legolas.emea.dhcp.ti.com> <20110222215923.GB28740@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]:53430 "EHLO na3sys009aog111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753620Ab1CAAfK (ORCPT ); Mon, 28 Feb 2011 19:35:10 -0500 Received: by mail-yw0-f42.google.com with SMTP id 1so2239171ywh.1 for ; Mon, 28 Feb 2011 16:35:09 -0800 (PST) In-Reply-To: <20110222215923.GB28740@sirena.org.uk> (Mark Brown's message of "Tue, 22 Feb 2011 21:59:23 +0000") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Mark Brown Cc: Felipe Balbi , "Koyamangalath, Abhilash" , "linux-omap@vger.kernel.org" Mark Brown writes: > On Fri, Feb 18, 2011 at 01:12:37PM +0200, Felipe Balbi wrote: > >> On Fri, Feb 18, 2011 at 04:39:48PM +0530, Koyamangalath, Abhilash wrote: >> > I understand, but is there a subtle reason why are starting from >> > an erroneous-looking -1 rather than a more natural 0 (or 1 ?). > >> -1 means no ID. The IDs are zero-based, so we can't use zero. Just >> change that value and see how things change on sysfs and dmesg then you >> will know what I'm talking about. That's just an implementation decision >> of using -1 to signify "no ID needed". > > Though looking at the report it looks like the omap_device print that's > done during boot is doing the wrong thing here and displaying the -1 > instead of masking it from the print which is what's expected. Agreed. Abhilash, Just send a patch to fix the omap_device printk which is the confusing part. Kevin