Re: [PATCH 2/8] OMAP3:GPIO:Add support for early platform gpio device

Tony Lindgren
2010-04-01T09:10:12Z

* Varadarajan, Charulatha <charu@ti.com> [100401 01:54]:
>
>
> > -----Original Message-----
> > From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
> > Sent: Thursday, April 01, 2010 12:53 PM
> > To: Varadarajan, Charulatha
> > Cc: linux-omap@vger.kernel.org; Nayak, Rajendra; paul@pwsan.com; tony@atomide.com
> > Subject: Re: [PATCH 2/8] OMAP3:GPIO:Add support for early platform gpio device
> >
> > On Wed, Mar 31, 2010 at 02:23:53PM +0200, ext Charulatha V wrote:
> > >This patch adds support for implementing OMAP3 GPIO as an
> > >early platform device and adds gpio_init specific to OMAP3
> > >
> > >This patch adds device structures for each GPIO device in
> > >OMAP3 architecture. These strutures are not created in a
> > >separate *_data.c file because these structures would be
> > >removed once the driver gets adapted to HWMOD way.
> > >
> > >Signed-off-by: Charulatha V <charu@ti.com>
> > >---
> > > arch/arm/mach-omap2/gpio3xxx.c | 351 +++++++++++++++++++++++++++++++
> > > arch/arm/mach-omap2/include/mach/gpio.h | 13 +-
> > > 2 files changed, 363 insertions(+), 1 deletions(-)
> > > create mode 100644 arch/arm/mach-omap2/gpio3xxx.c
> > >
> > >--- /dev/null
> > >+++ b/arch/arm/mach-omap2/gpio3xxx.c
> > >+
> > >+static struct __initdata omap_gpio_platform_data omap3_gpio1_config = {
> > >+ .ick_name = "gpio1_ick",
> > >+ .dbck_name = "gpio1_dbck",
> >
> > do not pass clock names. Update the clkdev entries clk*_data.c
>
> Agreed. These patches are in preparation for HWMOD. Once GPIO driver gets
> adapted to HWMOD, this would be removed.

Still need to change it before hwmod. No passing of clock names has been
needed for quite a while now.

Tony