RE: [PATCH 3/8] OMAP2:GPIO:Add support for early platform gpio device

Varadarajan, Charulatha
2010-04-01T09:16:32Z

> -----Original Message-----
> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
> Sent: Thursday, April 01, 2010 2:29 PM
> To: Varadarajan, Charulatha
> Cc: Balbi Felipe (Nokia-D/Helsinki); linux-omap@vger.kernel.org; Nayak, Rajendra;
> paul@pwsan.com; tony@atomide.com
> Subject: Re: [PATCH 3/8] OMAP2:GPIO:Add support for early platform gpio device
>
> On Thu, Apr 01, 2010 at 10:53:48AM +0200, ext Varadarajan, Charulatha wrote:
> >
> >
> >> -----Original Message-----
> >> From: Felipe Balbi [mailto:felipe.balbi@nokia.com]
> >> Sent: Thursday, April 01, 2010 12:56 PM
> >> To: Varadarajan, Charulatha
> >> Cc: linux-omap@vger.kernel.org; Nayak, Rajendra; paul@pwsan.com;
> tony@atomide.com
> >> Subject: Re: [PATCH 3/8] OMAP2:GPIO:Add support for early platform gpio device
> >>
> >> On Wed, Mar 31, 2010 at 02:23:54PM +0200, ext Charulatha V wrote:
> >> >+static inline struct gpio_bank *omap2_get_gpio_bank(int gpio,
> >> >+ struct gpio_bank *gpio_bank)
> >> >+{
> >> >+ if (cpu_is_omap24xx())
> >> >+ return &gpio_bank[gpio >> 5];
> >> >+ BUG();
> >>
> >> so if we build support omap 2420 and 3430 we will have a BUG() ??
> >
> >Multi-OMAP build will not give a BUG(). If this function is called
> >during non-3430 OMAP arch, it will have a BUG().
>
> still, you shouldn't sprinkle BUG() around the code this can cause some
> hard to find kernel oopses. Just return NULL.

Okay.

>
> --
> balbi