RE: [PATCH 7/8] OMAP2PLUS:GPIO:Move gpio_init from board files to init_common_hw

Varadarajan, Charulatha
2010-04-01T10:50:12Z

> -----Original Message-----
> From: Tony Lindgren [mailto:tony@atomide.com]
> Sent: Thursday, April 01, 2010 3:03 PM
> To: Varadarajan, Charulatha
> Cc: linux-omap@vger.kernel.org; Nayak, Rajendra; paul@pwsan.com
> Subject: Re: [PATCH 7/8] OMAP2PLUS:GPIO:Move gpio_init from board files to
> init_common_hw
>
> * Charulatha V <charu@ti.com> [100331 05:15]:
> > This is preparation for early platform device implementation
> > for GPIO in OMAP2PLUS. This patch moves initialization of gpio
> > from board files to omap2_init_common_hw API in io.c
> >
> > Init_irq needs to be done before gpio_init, the init_irq
> > is called before omap2_init_common_hw in board files
>
> Nope. We want to call omap2_init_common_hw as early as
> possible, otherwise the cpu detection won't work.
>
> What omaps have you tested this series on?

I tested it on 3430SDP, 4430SDP and zoom3 and did not face
any problem. I will keep this point in mind while creating
next version of patches.

>
> Tony