Re: [PATCH v6] OMAP UART: Add omap-serial driver support.

[Kevin Hilman <khilman@deeprootsystems.com>]

"Govindraj.R" <govindraj.raja@ti.com> writes:

> From 81fe9a08684830e84e64bed57c7f90e7461a5375 Mon Sep 17 00:00:00 2001
> From: Govindraj R <govindraj.raja@ti.com>
> Date: Thu, 18 Feb 2010 19:34:04 +0530
> Subject: [PATCH] OMAP UART: Add omap-serial driver support.

Please drop this stuff from te mail body.  It's included in the mail
header and makes for extra junk to be manually removed by maintainers.

Also Subject should be something like "serial: add OMAP high-speed UART driver"

For the changelog of a new driver, you should also describe what
devices this driver will be used on etc.  Assume the reader isn't
familiar with the driver or device.

> This patch adds support for OMAP-HIGH SPEED UART Controller.
> It adds support for the following features:

"adds" support to what?

> 1. It supports Interrupt mode and DMA mode of operation.
> 2. Supports Hardware flow control and software flow control.
> 3. Debug Console support on all UARTs.

I think the changelog needs some work.  It should especially describe
that it is based on the 8250 driver and highlight the
additions/differences from the 8250 driver.

> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Signed-off-by: Govindraj R <govindraj.raja@ti.com>
> ---
> Incorporating Comments from Tony,Olof,Kevin.


Other than the changelog, this looks pretty good to me.   

Oh, you should also update the copyrights to 2010.

After that and Olof's comments, it should be submitted to linux-serial
and LKML.

I also tested this with the PM branch on SDP, omap3evm, and Beagle
including off mode and things are working well.

Tested-by: Kevin Hilman <khilman@deeprootsystems.com>

Kevin