Re: [PATCH 01/13] Revert "ARM: OMAP: Mask interrupts when disabling interrupts, v2"

[Kevin Hilman <khilman@deeprootsystems.com>]

Kim Kyuwon <q1.kim@samsung.com> writes:

> Kevin Hilman wrote:
>> This reverts commit 5461af5af5c6a7fee78978aafe720541bf3a2f55.
>>
>> Adding a disable hook to the irq_chip is not the way to fix the
>> problem being addressed by this patch.  Instead, we need to fix
>> support for [enable|disable]_irq_wake().
>
> Agree with you if we can use disable_irq_wake for MPU Interrupt with
> not masking the IRQ. Can you explain how we can fix support for
> disable_irq_wake() for omap_irq_chip?

Yes.  The PRCM has a wake-enable per device bit that can be set (see
PM_WKEN_<pwrdm>) to control device wakeup enables.

But the implemenation of that should not hold up this revert because
this patch breaks *all* wakeups since the PRCM interrupt itself is
disabled in the suspend path.

As a workaround for your USB problem that this patch was initially
intended to fix you could manually disable USB OTG wakeups like this:

	wken = prm_read_mod_reg(CORE_MOD, PM_WKEN);
        wken &= ~OMAP3430_EN_HSOTGUSB; 
	prm_write_mod_reg(wken, CORE_MOD, PM_WKEN);
	
At least until the irq_wake stuff is fixed.

Kevin