Re: [PATCH 00/05] OMAP3: CPUidle driver

[Kevin Hilman <khilman@deeprootsystems.com>]

Kevin Hilman <khilman@deeprootsystems.com> writes:

> "Rajendra Nayak" <rnayak@ti.com> writes:
>
>> This patch set implements Cpuidle driver for OMAP3 platforms. It is
>> validated on the 3430SDP (using the omap_3430sdp_min_defconfig) and
>> applies on the pm-20081006 branch.
>
> Excellent.  Thank you.  I'll pull into pm-20081006 today.
>
> One question: You have C6 to hit chip-off, but it is never enabled.
> Has this been tested?  Enabling it allows me to hit chip OFF, but it
> never comes back from OFF-mode.  I will push some patches to make this
> work with /sys/power/enable_off_mode.

I got this to work on custom HW, but not on 3430SDP.  Can you confirm
whether or not you can use C6 on 3430SDP?  Off-in-idle without CPUidle
seems to work, but not with CPUidle + C6.

Kevin

> Some minor problems that I will fixup when rebasing to the next pm
> branch:
>
>  - You removed C0, but all the comments still refer to it
>  - /sys/power/enable_off_mode doesn't affect off-mode states
>    in CPUidle
>
> patch 1:
>  - I still don't like the #ifdefs for the init sequence.
>
> patch 2:
>  - checkpatch warning
>
> Kevin
>
>> The following C states are defined and used 
>>
>>  *      C0 . System executing code (Not an idle state)
>>  *      C1 . MPU WFI + Core active
>>  *      C2 . MPU CSWR + Core active
>>  *      C3 . MPU OFF + Core active
>>  *      C4 . MPU CSWR + Core CSWR
>>  *      C5 . MPU OFF + Core CSWR
>>  *      C6 . MPU OFF + Core OFF
>>
>> CPUidle support is not enabled by default in any of the defconfigs and hence has to enabled seperately 
>> if you plan to test these patches.
>>
>> CPUIdle ---> [*] CPU idle PM support
>>
>> regards,
>> Rajendra