public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: [patch twl 1/2] remove <linux/i2c/twl4030-rtc.h>
Date: Mon, 06 Oct 2008 17:57:14 +0300	[thread overview]
Message-ID: <87hc7pvkj9.fsf@deeprootsystems.com> (raw)
In-Reply-To: <200810012342.50866.david-b@pacbell.net> (David Brownell's message of "Wed\, 1 Oct 2008 23\:42\:50 -0700")

David Brownell <david-b@pacbell.net> writes:

> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Remove <linux/i2c/twl4030-rtc.h> by moving all the relevant contents
> into the driver itself, and removing the rest.  Stuff removed included
> many useless bitmasks, and remnants of the platform data hook.
>
> Add markers inside the rtc driver to split sections apart:  first
> data structure declarations, then the RTC driver, then platform bus
> glue for it all.
>
> There's still an issue with the twl4030-pwrirq.h registers ... this
> driver has no business touching them!  This patch at least switches
> away from having private versions of those register definitions, and
> removes some unnecessary accesses to them.
>
> No functional changes, just shrinkage.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

In addition, remove the #include of twl4030-rtc.h from board-3430sdp.c

Kevin


>From aa394ce81d3c63f64ae27e89c2588950aaee2995 Mon Sep 17 00:00:00 2001
From: Kevin Hilman <khilman@deeprootsystems.com>
Date: Mon, 6 Oct 2008 17:52:43 +0300
Subject: [PATCH] ARM: OMAP3: Remove include of removed twl4030-rtc.h

Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
 arch/arm/mach-omap2/board-3430sdp.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
index 4264b68..56f28ae 100644
--- a/arch/arm/mach-omap2/board-3430sdp.c
+++ b/arch/arm/mach-omap2/board-3430sdp.c
@@ -40,7 +40,6 @@
 #include <mach/keypad.h>
 #include <mach/dma.h>
 #include <mach/gpmc.h>
-#include <linux/i2c/twl4030-rtc.h>
 
 #include <asm/io.h>
 #include <asm/delay.h>
-- 
1.6.0


  parent reply	other threads:[~2008-10-06 14:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02  6:42 [patch twl 1/2] remove <linux/i2c/twl4030-rtc.h> David Brownell
2008-10-02  9:05 ` Felipe Balbi
2008-10-03 13:28   ` Tony Lindgren
2008-10-03 14:21     ` David Brownell
2008-10-06 14:57 ` Kevin Hilman [this message]
2008-10-06 16:39   ` David Brownell
2008-10-07  8:03     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hc7pvkj9.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=david-b@pacbell.net \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox